You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by razvan100 <gi...@git.apache.org> on 2017/10/11 17:40:16 UTC
[GitHub] flink pull request #4809: [FLINK-7803][Documentation] Add missing savepoint ...
GitHub user razvan100 opened a pull request:
https://github.com/apache/flink/pull/4809
[FLINK-7803][Documentation] Add missing savepoint information
This fixes FLINK-7803 by emphasizing the savepoint save location should be on a distributed file-system.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/razvan100/flink patch-3
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4809.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4809
----
commit a3fa67e0dbc3498a5a916dbe1f7702366d793867
Author: Razvan <ra...@yahoo.com>
Date: 2017-10-11T17:38:50Z
[FLINK-7803] Add missing savepoint information
This fixes FLINK-7803 by emphasizing the savepoint save location should be on a distributed file-system.
----
---
[GitHub] flink pull request #4809: [FLINK-7803][Documentation] Add missing savepoint ...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/4809#discussion_r166008336
--- Diff: docs/ops/state/savepoints.md ---
@@ -120,6 +120,10 @@ This will atomically trigger a savepoint for the job with ID `:jobid` and cancel
If you don't specify a target directory, you need to have [configured a default directory](#configuration). Otherwise, cancelling the job with a savepoint will fail.
+<div class="alert alert-warning">
--- End diff --
👍
---
[GitHub] flink pull request #4809: [FLINK-7803][Documentation] Add missing savepoint ...
Posted by GJL <gi...@git.apache.org>.
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4809#discussion_r166001086
--- Diff: docs/ops/state/savepoints.md ---
@@ -120,6 +120,10 @@ This will atomically trigger a savepoint for the job with ID `:jobid` and cancel
If you don't specify a target directory, you need to have [configured a default directory](#configuration). Otherwise, cancelling the job with a savepoint will fail.
+<div class="alert alert-warning">
--- End diff --
Should be something like:
```
<div class="alert alert-warning">
<strong>Attention:</strong> <code>targetDirectory</code> has to be a location accessible by both the JobManager(s) and TaskManager(s), e.g., a location on a distributed file system.
</div>
```
because markdown is not rendered within HTML tags.
Also, the *warning* you have added is currently in the *Cancel Job with Savepoint* section. I think it should be moved to the section above (*Trigger a Savepoint*), or somewhere else since it does not only apply to the cancelation case.
@uce
---
[GitHub] flink issue #4809: [FLINK-7803][Documentation] Add missing savepoint informa...
Posted by razvan100 <gi...@git.apache.org>.
Github user razvan100 commented on the issue:
https://github.com/apache/flink/pull/4809
@aljoscha Hi, do you know if it's possible to retrigger the build? Don't believe it fails because of my change. Also, how can I add reviewers? Thanks!
---
[GitHub] flink issue #4809: [FLINK-7803][Documentation] Add missing savepoint informa...
Posted by razvan100 <gi...@git.apache.org>.
Github user razvan100 commented on the issue:
https://github.com/apache/flink/pull/4809
Okay, so if you account for it in the review then I don't need to make another empty commit. Thanks!
---
[GitHub] flink issue #4809: [FLINK-7803][Documentation] Add missing savepoint informa...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4809
will merge this while addressing the comments
---
[GitHub] flink issue #4809: [FLINK-7803][Documentation] Add missing savepoint informa...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4809
@razvan100 You can re-trigger the build by adding a new commit (even en empty one). However, please don't do this for the sake of achieving a picture perfect build (in particular for documentation changes which can't affect the build anyway); we are aware of certain test instabilities and account for those in the review.
As for reviewers, you cannot explicitly request a review. You can mention committers if (as you did with aljoscha) but I would ask you to refrain from doing so unless absolutely necessary.
---
[GitHub] flink issue #4809: [FLINK-7803][Documentation] Add missing savepoint informa...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4809
@razvan100 I've merged the PR, could you close it?
---
[GitHub] flink pull request #4809: [FLINK-7803][Documentation] Add missing savepoint ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4809
---
[GitHub] flink issue #4809: [FLINK-7803][Documentation] Add missing savepoint informa...
Posted by GJL <gi...@git.apache.org>.
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/4809
Thank you @zentol
---