You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by "vkagamlyk (via GitHub)" <gi...@apache.org> on 2023/10/26 16:41:23 UTC
[PR] [TINKERPOP-2964] Fixed bug in `replaceLocalChild`. [tinkerpop]
vkagamlyk opened a new pull request, #2309:
URL: https://github.com/apache/tinkerpop/pull/2309
Fixed bug in `replaceLocalChild` where child traversal was not correctly integrated.
https://issues.apache.org/jira/browse/TINKERPOP-2964
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [TINKERPOP-2964] Fixed bug in `replaceLocalChild`. [tinkerpop]
Posted by "xiazcy (via GitHub)" <gi...@apache.org>.
xiazcy commented on PR #2309:
URL: https://github.com/apache/tinkerpop/pull/2309#issuecomment-1781776661
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [TINKERPOP-2964] Fixed bug in `replaceLocalChild`. [tinkerpop]
Posted by "vkagamlyk (via GitHub)" <gi...@apache.org>.
vkagamlyk commented on PR #2309:
URL: https://github.com/apache/tinkerpop/pull/2309#issuecomment-1781859934
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [TINKERPOP-2964] Fixed bug in `replaceLocalChild`. [tinkerpop]
Posted by "Cole-Greer (via GitHub)" <gi...@apache.org>.
Cole-Greer commented on PR #2309:
URL: https://github.com/apache/tinkerpop/pull/2309#issuecomment-1781750877
LGTM, VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [TINKERPOP-2964] Fixed bug in `replaceLocalChild`. [tinkerpop]
Posted by "vkagamlyk (via GitHub)" <gi...@apache.org>.
vkagamlyk merged PR #2309:
URL: https://github.com/apache/tinkerpop/pull/2309
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [TINKERPOP-2964] Fixed bug in `replaceLocalChild`. [tinkerpop]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2309:
URL: https://github.com/apache/tinkerpop/pull/2309#issuecomment-1781521963
## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2309?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#2309](https://app.codecov.io/gh/apache/tinkerpop/pull/2309?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (3f4e395) into [3.6-dev](https://app.codecov.io/gh/apache/tinkerpop/commit/f28c1db9bfd010e0eb1b10f0a1cb5b01fbefeb4d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f28c1db) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## 3.6-dev #2309 +/- ##
==========================================
Coverage 75.17% 75.17%
- Complexity 12291 12294 +3
==========================================
Files 1056 1056
Lines 63364 63371 +7
Branches 6924 6924
==========================================
+ Hits 47633 47639 +6
- Misses 13158 13160 +2
+ Partials 2573 2572 -1
```
| [Files](https://app.codecov.io/gh/apache/tinkerpop/pull/2309?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../process/traversal/step/filter/PathFilterStep.java](https://app.codecov.io/gh/apache/tinkerpop/pull/2309?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9zdGVwL2ZpbHRlci9QYXRoRmlsdGVyU3RlcC5qYXZh) | `90.19% <100.00%> (+0.19%)` | :arrow_up: |
| [...cess/traversal/step/filter/WherePredicateStep.java](https://app.codecov.io/gh/apache/tinkerpop/pull/2309?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9zdGVwL2ZpbHRlci9XaGVyZVByZWRpY2F0ZVN0ZXAuamF2YQ==) | `95.00% <100.00%> (+0.08%)` | :arrow_up: |
| [...p/gremlin/process/traversal/step/map/PathStep.java](https://app.codecov.io/gh/apache/tinkerpop/pull/2309?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9zdGVwL21hcC9QYXRoU3RlcC5qYXZh) | `95.65% <100.00%> (+0.09%)` | :arrow_up: |
| [...remlin/process/traversal/step/map/ProjectStep.java](https://app.codecov.io/gh/apache/tinkerpop/pull/2309?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9zdGVwL21hcC9Qcm9qZWN0U3RlcC5qYXZh) | `94.11% <100.00%> (+0.17%)` | :arrow_up: |
| [...gremlin/process/traversal/step/map/SelectStep.java](https://app.codecov.io/gh/apache/tinkerpop/pull/2309?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9zdGVwL21hcC9TZWxlY3RTdGVwLmphdmE=) | `92.59% <100.00%> (+0.13%)` | :arrow_up: |
| [...p/gremlin/process/traversal/step/map/TreeStep.java](https://app.codecov.io/gh/apache/tinkerpop/pull/2309?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9zdGVwL21hcC9UcmVlU3RlcC5qYXZh) | `97.67% <100.00%> (+0.05%)` | :arrow_up: |
| [.../traversal/step/sideEffect/TreeSideEffectStep.java](https://app.codecov.io/gh/apache/tinkerpop/pull/2309?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9zdGVwL3NpZGVFZmZlY3QvVHJlZVNpZGVFZmZlY3RTdGVwLmphdmE=) | `97.43% <100.00%> (+0.06%)` | :arrow_up: |
... and [7 files with indirect coverage changes](https://app.codecov.io/gh/apache/tinkerpop/pull/2309/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [TINKERPOP-2964] Fixed bug in `replaceLocalChild`. [tinkerpop]
Posted by "rdtr (via GitHub)" <gi...@apache.org>.
rdtr commented on PR #2309:
URL: https://github.com/apache/tinkerpop/pull/2309#issuecomment-1781652822
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org