You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/12/06 15:17:19 UTC

[GitHub] [cloudstack] DaanHoogland commented on pull request #6947: Allow password definition during VM deploy

DaanHoogland commented on PR #6947:
URL: https://github.com/apache/cloudstack/pull/6947#issuecomment-1339538586

   please guard debug logging statements if they need parameter evaluation. code looks good otherwise I think, but I will not approve logging like this. heavy loaded systems ar benefitted by not having the extra string operations when they don´t want to.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org