You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/04/02 19:38:02 UTC
[GitHub] [incubator-druid] justinborromeo commented on a change in pull
request #7373: SQL support for time-ordered scan
justinborromeo commented on a change in pull request #7373: SQL support for time-ordered scan
URL: https://github.com/apache/incubator-druid/pull/7373#discussion_r271464703
##########
File path: sql/src/main/java/org/apache/druid/sql/calcite/rel/DruidQuery.java
##########
@@ -984,97 +1001,27 @@ public ScanQuery toScanQuery()
? 0L
: (long) limitSpec.getLimit();
+ ScanQuery.Order order;
+ if (limitSpec == null || limitSpec.getColumns().size() == 0) {
+ order = ScanQuery.Order.NONE;
+ } else if (limitSpec.getColumns().get(0).getDirection() == OrderByColumnSpec.Direction.ASCENDING) {
Review comment:
I think we decided on adding a `ScanQuery.Order enum` because `OrderByColumnSpec` didn't really support a no-ordering case. See https://github.com/apache/incubator-druid/pull/7133#discussion_r266170777
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org