You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "parisni (via GitHub)" <gi...@apache.org> on 2023/07/20 16:20:58 UTC

[GitHub] [hudi] parisni opened a new pull request, #9245: Fix parquet bloom filters impl and tests

parisni opened a new pull request, #9245:
URL: https://github.com/apache/hudi/pull/9245

   ### Change Logs
   
   This makes the parquet bloom filter work correctly. After trying out the #8716 the bloom where not being created
   
   1. the reflexion usage was incorrect and this was silently doing nothing
   1. The reason is the test where not verifying correctly the bloom where created. A side effect of parquet stats where used in place of bloom in newer versions of parquet
   
   This PR :
   1. fixes the impl
   1. fixes the test
   
   Double check with parquet-cli after the patch confirmed the bloom exist. We cannot yet use such checks since only recent version of parquet can verify the bloom exist
   
   ### Impact
   
   _Describe any public API or user-facing feature change or any performance impact._
   
   ### Risk level (write none, low medium or high below)
   
   _If medium or high, explain what verification was done to mitigate the risks._
   
   ### Documentation Update
   
   _Describe any necessary documentation update if there is any new feature, config, or user-facing change_
   
   - _The config description must be updated if new configs are added or the default value of the configs are changed_
   - _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
     ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
     changes to the website._
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #9245: Fix parquet bloom filters impl and tests

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9245:
URL: https://github.com/apache/hudi/pull/9245#issuecomment-1644826558

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "02bae1a147ee036a3ac412ba51abf9d5d111aab1",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18733",
       "triggerID" : "02bae1a147ee036a3ac412ba51abf9d5d111aab1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "02bae1a147ee036a3ac412ba51abf9d5d111aab1",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18732",
       "triggerID" : "02bae1a147ee036a3ac412ba51abf9d5d111aab1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 02bae1a147ee036a3ac412ba51abf9d5d111aab1 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18733) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18732) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] parisni commented on pull request #9245: Fix parquet bloom filters impl and tests

Posted by "parisni (via GitHub)" <gi...@apache.org>.
parisni commented on PR #9245:
URL: https://github.com/apache/hudi/pull/9245#issuecomment-1730022198

   @gsudhanshu from the jira tracker this should be in upcoming 0.14 version. 
   
   https://issues.apache.org/jira/browse/HUDI-6226
   
   But I couldn't find the commit in the release. Not sure then


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #9245: Fix parquet bloom filters impl and tests

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9245:
URL: https://github.com/apache/hudi/pull/9245#issuecomment-1644871258

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "02bae1a147ee036a3ac412ba51abf9d5d111aab1",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18733",
       "triggerID" : "02bae1a147ee036a3ac412ba51abf9d5d111aab1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "02bae1a147ee036a3ac412ba51abf9d5d111aab1",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18732",
       "triggerID" : "02bae1a147ee036a3ac412ba51abf9d5d111aab1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 02bae1a147ee036a3ac412ba51abf9d5d111aab1 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18733) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18732) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #9245: Fix parquet bloom filters impl and tests

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9245:
URL: https://github.com/apache/hudi/pull/9245#issuecomment-1644253940

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "02bae1a147ee036a3ac412ba51abf9d5d111aab1",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "02bae1a147ee036a3ac412ba51abf9d5d111aab1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 02bae1a147ee036a3ac412ba51abf9d5d111aab1 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] danny0405 merged pull request #9245: Fix parquet bloom filters impl and tests

Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #9245:
URL: https://github.com/apache/hudi/pull/9245


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #9245: Fix parquet bloom filters impl and tests

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9245:
URL: https://github.com/apache/hudi/pull/9245#issuecomment-1644265423

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "02bae1a147ee036a3ac412ba51abf9d5d111aab1",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18733",
       "triggerID" : "02bae1a147ee036a3ac412ba51abf9d5d111aab1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 02bae1a147ee036a3ac412ba51abf9d5d111aab1 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18733) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] gsudhanshu commented on pull request #9245: Fix parquet bloom filters impl and tests

Posted by "gsudhanshu (via GitHub)" <gi...@apache.org>.
gsudhanshu commented on PR #9245:
URL: https://github.com/apache/hudi/pull/9245#issuecomment-1731249502

   @parisni can you kindly escalate this and ensure that this commit comes in 0.14 v release
   
   we need it, thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] gsudhanshu commented on pull request #9245: Fix parquet bloom filters impl and tests

Posted by "gsudhanshu (via GitHub)" <gi...@apache.org>.
gsudhanshu commented on PR #9245:
URL: https://github.com/apache/hudi/pull/9245#issuecomment-1729384534

   hi @danny0405 @parisni ,
   
   when would this feature be released?
   
   Thanks & Regards,
   Sudhanshu


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] parisni commented on pull request #9245: Fix parquet bloom filters impl and tests

Posted by "parisni (via GitHub)" <gi...@apache.org>.
parisni commented on PR #9245:
URL: https://github.com/apache/hudi/pull/9245#issuecomment-1731937879

   Hi, the parquet bloom filter will be available in the 0.14.x release
   see
   https://github.com/apache/hudi/blob/release-0.14.0-rc3/hudi-common/src/main/java/org/apache/hudi/io/storage/HoodieBaseParquetWriter.java#L78
   
   On Fri, 2023-09-22 at 04:18 -0700, gsudhanshu wrote:
   > @parisni can you kindly escalate this and ensure that this commit
   > comes in 0.14 v release
   > we need it, thanks
   > —
   > Reply to this email directly, view it on GitHub, or unsubscribe.
   > You are receiving this because you were mentioned.Message ID:
   > ***@***.***>
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] parisni commented on pull request #9245: Fix parquet bloom filters impl and tests

Posted by "parisni (via GitHub)" <gi...@apache.org>.
parisni commented on PR #9245:
URL: https://github.com/apache/hudi/pull/9245#issuecomment-1731784471

   OK let me drive this
   
   On September 22, 2023 11:18:49 AM UTC, gsudhanshu ***@***.***> wrote:
   >@parisni can you kindly escalate this and ensure that this commit comes in 0.14 v release
   >
   >we need it, thanks
   >
   >-- 
   >Reply to this email directly or view it on GitHub:
   >https://github.com/apache/hudi/pull/9245#issuecomment-1731249502
   >You are receiving this because you were mentioned.
   >
   >Message ID: ***@***.***>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] parisni commented on pull request #9245: Fix parquet bloom filters impl and tests

Posted by "parisni (via GitHub)" <gi...@apache.org>.
parisni commented on PR #9245:
URL: https://github.com/apache/hudi/pull/9245#issuecomment-1644221959

   @danny0405 may you take a look on this ? 
   
   Thanks !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org