You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2021/07/28 23:18:38 UTC
[GitHub] [zookeeper] apatruni opened a new pull request #1732: add tab test
apatruni opened a new pull request #1732:
URL: https://github.com/apache/zookeeper/pull/1732
Adding a test case to StringUtils to ensure spaces expressed as something other than ' ' are covered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] apatruni commented on pull request #1732: ZOOKEEPER-4340 : add tab unit test for StringUtils#split
Posted by GitBox <gi...@apache.org>.
apatruni commented on pull request #1732:
URL: https://github.com/apache/zookeeper/pull/1732#issuecomment-890332202
@maoling thanks so much, looking forward to contributing more very soon!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] maoling commented on pull request #1732: ZOOKEEPER-4340 : add tab unit test for StringUtils#split
Posted by GitBox <gi...@apache.org>.
maoling commented on pull request #1732:
URL: https://github.com/apache/zookeeper/pull/1732#issuecomment-890304153
@apatruni LGTM
- If no other concerns, I'll merge it at next weekend(08-08).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] asfgit closed pull request #1732: ZOOKEEPER-4340 : add tab unit test for StringUtils#split
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1732:
URL: https://github.com/apache/zookeeper/pull/1732
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] maoling commented on pull request #1732: ZOOKEEPER-4340 : add tab unit test for StringUtils#split
Posted by GitBox <gi...@apache.org>.
maoling commented on pull request #1732:
URL: https://github.com/apache/zookeeper/pull/1732#issuecomment-894760667
@apatruni
Thanks for your contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] maoling closed pull request #1732: ZOOKEEPER-4340 : add tab unit test for StringUtils#split
Posted by GitBox <gi...@apache.org>.
maoling closed pull request #1732:
URL: https://github.com/apache/zookeeper/pull/1732
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] apatruni commented on pull request #1732: add tab test
Posted by GitBox <gi...@apache.org>.
apatruni commented on pull request #1732:
URL: https://github.com/apache/zookeeper/pull/1732#issuecomment-889091803
@maoling Thank you! I'm looking forward to contributting to zookeeper and wanted to start off with a somewhat simpler commit to get started. Created https://issues.apache.org/jira/browse/ZOOKEEPER-4340 for this. I will fix up the formatting issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] maoling commented on pull request #1732: add tab test
Posted by GitBox <gi...@apache.org>.
maoling commented on pull request #1732:
URL: https://github.com/apache/zookeeper/pull/1732#issuecomment-889017548
@apatruni
- Thanks for this contribution. It's better to create a [JIRA](https://issues.apache.org/jira/projects/ZOOKEEPER/) issue (sign up JIRA if you don't have an account) to bind this PR to a JIRA-ID. ZooKeeper uses the GitHub workflow. The contributor guideline is [here](https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute)
- This title: `add tab unit test for StringUtils#split` is better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org