[GitHub] [gobblin] hanghangliu commented on a diff in pull request #3699: [GOBBLIN-1836] Ensuring Task Reliability: Handling Job Cancellation and Graceful Exits for Error-Free Completion

["hanghangliu (via GitHub)" <gi...@apache.org>]

hanghangliu commented on code in PR #3699:
URL: https://github.com/apache/gobblin/pull/3699#discussion_r1207135215


##########
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelixTask.java:
##########
@@ -219,6 +228,7 @@ public void cancel() {
     log.info("Gobblin helix task cancellation invoked for jobId {}.", jobId);
     if (this.task != null ) {
       try {
+        this.isCanceled = true;

Review Comment:
   set the flag after task.cancel() is done?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org