You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/02/18 07:51:43 UTC

[GitHub] [hudi] guanziyue commented on a change in pull request #4264: [HUDI-2875] Make HoodieParquetWriter Thread safe and memory executor …

guanziyue commented on a change in pull request #4264:
URL: https://github.com/apache/hudi/pull/4264#discussion_r809748931



##########
File path: hudi-common/src/main/java/org/apache/hudi/common/util/queue/BoundedInMemoryQueue.java
##########
@@ -204,6 +204,7 @@ private boolean expectMoreRecords() {
    * singleton iterator for this queue.
    */
   private Option<O> readNextRecord() {
+    checkIfInterrupted();

Review comment:
       Agree with you, I missed it. Let me think about if there is any other way to notify consumer so that they can stop asap when queue received a termination signal.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org