[GitHub] rhtyd commented on a change in pull request #2312: CLOUDSTACK-7793 Create Snaphot with quiesce option set to true fails ?

[GitBox <gi...@apache.org>]

rhtyd commented on a change in pull request #2312: CLOUDSTACK-7793 Create Snaphot with quiesce option set to true fails ?
URL: https://github.com/apache/cloudstack/pull/2312#discussion_r150003501
 
 

 ##########
 File path: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java
 ##########
 @@ -604,7 +604,7 @@ private boolean orchestrateDeleteVMSnapshot(Long vmSnapshotId) {
         _accountMgr.checkAccess(caller, null, true, vmSnapshot);
 
         // check VM snapshot states, only allow to delete vm snapshots in created and error state
-        if (VMSnapshot.State.Ready != vmSnapshot.getState() && VMSnapshot.State.Expunging != vmSnapshot.getState() && VMSnapshot.State.Error != vmSnapshot.getState()) {
+        if (VMSnapshot.State.Ready != vmSnapshot.getState() && VMSnapshot.State.Expunging != vmSnapshot.getState() && VMSnapshot.State.Error != vmSnapshot.getState() && VMSnapshot.State.Allocated != vmSnapshot.getState()) {
             throw new InvalidParameterValueException("Can't delete the vm snapshotshot " + vmSnapshotId + " due to it is not in Created or Error, or Expunging State");
 
 Review comment:
   Update error message as weel @yvsubhash 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services