You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/09/12 23:38:35 UTC

[GitHub] [beam] dannymartinm commented on a diff in pull request #23163: [GitHub Actions] - Updates in Python Tests to runs-on Self-hosted runners

dannymartinm commented on code in PR #23163:
URL: https://github.com/apache/beam/pull/23163#discussion_r969016679


##########
.github/workflows/python_tests.yml:
##########
@@ -16,40 +16,40 @@
 # under the License.
 
 # To learn more about GitHub Actions in Apache Beam check the CI.md
-
 name: Python tests
-
 on:
   schedule:
     - cron: '10 2 * * *'
   push:
     branches: ['master', 'release-*']
-    tags: 'v*'
-  pull_request:
+    tags: ['v*']
+  pull_request_target:
     branches: ['master', 'release-*']
-    tags: 'v*'
+    tags: ['v*']
     paths: ['sdks/python/**', 'model/**']
   workflow_dispatch:
     inputs:
       runDataflow:
         description: 'Type "true" if you want to run Dataflow tests (GCP variables must be configured, check CI.md)'
-        default: false
-
+        default: 'false'
+        required: true

Review Comment:
   It was only added to remove the Schema Validation Warning: _"Add missing property `required`"_. But for sure we can either remove it or set is as `false`. What do you think would be the best? Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org