[GitHub] [pulsar] jerrypeng commented on a change in pull request #10491: [Functions] Adding “numListenerThreads” configuration parameter in WorkerConfig . #8575

[GitBox <gi...@apache.org>]

jerrypeng commented on a change in pull request #10491:
URL: https://github.com/apache/pulsar/pull/10491#discussion_r627920821



##########
File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/thread/ThreadRuntimeFactory.java
##########
@@ -79,14 +79,14 @@ public ThreadRuntimeFactory(String threadGroupName, String pulsarServiceUrl, Str
                                 String pulsarWebServiceUrl) throws Exception {
         initialize(threadGroupName, Optional.empty(), pulsarServiceUrl, authConfig,
                 storageServiceUrl, null, secretsProvider, collectorRegistry, narExtractionDirectory,
-                rootClassLoader, exposePulsarAdminClientEnabled, pulsarWebServiceUrl, Optional.empty());
+                rootClassLoader, exposePulsarAdminClientEnabled, pulsarWebServiceUrl, Optional.empty(),1);

Review comment:
       Why are we setting the number of listener threads here to be one?  I think this config should also be respected with using the other runtimes as well.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org