You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Patrick Kling (JIRA)" <ji...@apache.org> on 2010/10/29 01:11:21 UTC
[jira] Created: (HADOOP-7013) Add boolean field isCorrupt to
BlockLocation
Add boolean field isCorrupt to BlockLocation
--------------------------------------------
Key: HADOOP-7013
URL: https://issues.apache.org/jira/browse/HADOOP-7013
Project: Hadoop Common
Issue Type: Improvement
Reporter: Patrick Kling
This is needed to allow DFSClient.getBlockLocations to notify the calling application when returning a BlockLocation that corresponds to a corrupt block. Currently, this happens when there are no uncorrupted replicas of a requested block.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HADOOP-7013) Add boolean field isCorrupt to
BlockLocation
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang resolved HADOOP-7013.
-----------------------------------
Resolution: Fixed
Fix Version/s: 0.22.0
Release Note: This patch has changed the serialization format of BlockLocation.
Hadoop Flags: [Incompatible change, Reviewed]
I've just committed this. Thanks, Patrick!
> Add boolean field isCorrupt to BlockLocation
> --------------------------------------------
>
> Key: HADOOP-7013
> URL: https://issues.apache.org/jira/browse/HADOOP-7013
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Patrick Kling
> Assignee: Patrick Kling
> Fix For: 0.22.0
>
> Attachments: HADOOP-7013.patch
>
>
> This is needed to allow DFSClient.getBlockLocations to notify the calling application when returning a BlockLocation that corresponds to a corrupt block. Currently, this happens when there are no uncorrupted replicas of a requested block.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-7013) Add boolean field isCorrupt to
BlockLocation
Posted by "Patrick Kling (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Kling updated HADOOP-7013:
----------------------------------
Attachment: HADOOP-7013.patch
Review board: https://reviews.apache.org/r/26/
> Add boolean field isCorrupt to BlockLocation
> --------------------------------------------
>
> Key: HADOOP-7013
> URL: https://issues.apache.org/jira/browse/HADOOP-7013
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Patrick Kling
> Attachments: HADOOP-7013.patch
>
>
> This is needed to allow DFSClient.getBlockLocations to notify the calling application when returning a BlockLocation that corresponds to a corrupt block. Currently, this happens when there are no uncorrupted replicas of a requested block.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-7013) Add boolean field isCorrupt to
BlockLocation
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang reassigned HADOOP-7013:
-------------------------------------
Assignee: Patrick Kling
> Add boolean field isCorrupt to BlockLocation
> --------------------------------------------
>
> Key: HADOOP-7013
> URL: https://issues.apache.org/jira/browse/HADOOP-7013
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Patrick Kling
> Assignee: Patrick Kling
> Attachments: HADOOP-7013.patch
>
>
> This is needed to allow DFSClient.getBlockLocations to notify the calling application when returning a BlockLocation that corresponds to a corrupt block. Currently, this happens when there are no uncorrupted replicas of a requested block.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7013) Add boolean field isCorrupt to
BlockLocation
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12932827#action_12932827 ]
Hudson commented on HADOOP-7013:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #428 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/428/])
HADOOP-7013. Add boolean field isCorrupt to BlockLocation. Contributed by Patrick Kling.
> Add boolean field isCorrupt to BlockLocation
> --------------------------------------------
>
> Key: HADOOP-7013
> URL: https://issues.apache.org/jira/browse/HADOOP-7013
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Patrick Kling
> Assignee: Patrick Kling
> Fix For: 0.22.0
>
> Attachments: HADOOP-7013.patch
>
>
> This is needed to allow DFSClient.getBlockLocations to notify the calling application when returning a BlockLocation that corresponds to a corrupt block. Currently, this happens when there are no uncorrupted replicas of a requested block.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7013) Add boolean field isCorrupt to
BlockLocation
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12932672#action_12932672 ]
Hairong Kuang commented on HADOOP-7013:
---------------------------------------
On a second thought, Hadoop does not have a story for Writable backward compatibility yet. So this patch does not need to take care of this either. Instead we could simply mark this jira as incompatible.
So a +1 from me.
> Add boolean field isCorrupt to BlockLocation
> --------------------------------------------
>
> Key: HADOOP-7013
> URL: https://issues.apache.org/jira/browse/HADOOP-7013
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Patrick Kling
> Attachments: HADOOP-7013.patch
>
>
> This is needed to allow DFSClient.getBlockLocations to notify the calling application when returning a BlockLocation that corresponds to a corrupt block. Currently, this happens when there are no uncorrupted replicas of a requested block.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7013) Add boolean field isCorrupt to
BlockLocation
Posted by "Patrick Kling (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12932755#action_12932755 ]
Patrick Kling commented on HADOOP-7013:
---------------------------------------
ant test-path results:
{code}
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
[exec] Please justify why no new tests are needed for this patch.
[exec] Also please list what manual steps were performed to verify this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] -1 findbugs. The patch appears to introduce 2 new Findbugs warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
[exec]
[exec] +1 system test framework. The patch passed system test framework compile.
{code}
Tests are included with HDFS-1483. The findbugs warning are not caused by this patch (see MAPREDUCE-2172 for details).
> Add boolean field isCorrupt to BlockLocation
> --------------------------------------------
>
> Key: HADOOP-7013
> URL: https://issues.apache.org/jira/browse/HADOOP-7013
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Patrick Kling
> Assignee: Patrick Kling
> Attachments: HADOOP-7013.patch
>
>
> This is needed to allow DFSClient.getBlockLocations to notify the calling application when returning a BlockLocation that corresponds to a corrupt block. Currently, this happens when there are no uncorrupted replicas of a requested block.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7013) Add boolean field isCorrupt to
BlockLocation
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12932907#action_12932907 ]
Hudson commented on HADOOP-7013:
--------------------------------
Integrated in Hadoop-Common-trunk #515 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/515/])
HADOOP-7013. Add boolean field isCorrupt to BlockLocation. Contributed by Patrick Kling.
> Add boolean field isCorrupt to BlockLocation
> --------------------------------------------
>
> Key: HADOOP-7013
> URL: https://issues.apache.org/jira/browse/HADOOP-7013
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Patrick Kling
> Assignee: Patrick Kling
> Fix For: 0.22.0
>
> Attachments: HADOOP-7013.patch
>
>
> This is needed to allow DFSClient.getBlockLocations to notify the calling application when returning a BlockLocation that corresponds to a corrupt block. Currently, this happens when there are no uncorrupted replicas of a requested block.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7013) Add boolean field isCorrupt to
BlockLocation
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12932782#action_12932782 ]
Eli Collins commented on HADOOP-7013:
-------------------------------------
+1
Patch looks good to me.
> Add boolean field isCorrupt to BlockLocation
> --------------------------------------------
>
> Key: HADOOP-7013
> URL: https://issues.apache.org/jira/browse/HADOOP-7013
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Patrick Kling
> Assignee: Patrick Kling
> Attachments: HADOOP-7013.patch
>
>
> This is needed to allow DFSClient.getBlockLocations to notify the calling application when returning a BlockLocation that corresponds to a corrupt block. Currently, this happens when there are no uncorrupted replicas of a requested block.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7013) Add boolean field isCorrupt to
BlockLocation
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12932553#action_12932553 ]
Hairong Kuang commented on HADOOP-7013:
---------------------------------------
The patch looks good except for an incompatible change.
BlockLocation is not used in any wire-protocol, but for some reason it is Writable. So if by any chance somebody serialize this object in a file etc, then this patch makes it incompatible.
I would suggest that this patch does not change the serialization format. Since Hadoop does not use it over the wire, it won't do any harm.
> Add boolean field isCorrupt to BlockLocation
> --------------------------------------------
>
> Key: HADOOP-7013
> URL: https://issues.apache.org/jira/browse/HADOOP-7013
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Patrick Kling
> Attachments: HADOOP-7013.patch
>
>
> This is needed to allow DFSClient.getBlockLocations to notify the calling application when returning a BlockLocation that corresponds to a corrupt block. Currently, this happens when there are no uncorrupted replicas of a requested block.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.