You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/12/03 09:42:11 UTC

[GitHub] [orc] wgtmac commented on pull request #967: ORC-1053: Fix time zone offset precision when convert tool converts `LocalDateTime` to `Timestamp` is not consistent with the internal default precision of ORC

wgtmac commented on pull request #967:
URL: https://github.com/apache/orc/pull/967#issuecomment-985371206


   > > Also, cc @wgtmac since C++ tool seems to have the same issue according to the JIRA.
   > 
   > I have also debugged some of the C++ code. It looks like `strptime` can't convert values before 1970 on mac os.
   > 
   > https://github.com/apache/orc/blob/334bf1f2c605f38c7e75ec81d1dab93c31fc8459/tools/src/CSVFileImport.cc#L257
   
   Pre-1970 timestamp is a notorious issue. Not sure if these test cases will help: 
   https://github.com/apache/orc/blob/main/c%2B%2B/test/TestWriter.cc#L621
   https://github.com/apache/orc/blob/main/c%2B%2B/test/TestWriter.cc#L741


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org