[jira] [Commented] (HBASE-17440) [0.98] Make sure DelayedClosing chore is stopped as soon as an HConnection is closed

["Andrew Purtell (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-17440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15813004#comment-15813004 ] 

Andrew Purtell commented on HBASE-17440:
----------------------------------------

lgtm [~lhofhansl]


> [0.98] Make sure DelayedClosing chore is stopped as soon as an HConnection is closed
> ------------------------------------------------------------------------------------
>
>                 Key: HBASE-17440
>                 URL: https://issues.apache.org/jira/browse/HBASE-17440
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.98.24
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>         Attachments: 17440.txt
>
>
> We're seeing many issue with run-away ZK client connection in long running app servers. 10k or more send or event threads are happening frequently.
> While I looked around in the code I noticed that DelayedClosing closing is not immediately ended when an HConnection is closed, when there's an issue with HBase or ZK and client reconnect in a tight loop, this can lead temporarily to very many threads running. These will all get cleaned out after at most 60s, but during that time a lot of threads can be created.
> The fix is a one-liner. We'll likely file other issues soon.
> Interestingly branch-1 and beyond do not have this chore anymore, although - at least in branch-1 and later - I still see the ZooKeeperAliveConnection.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)