[GitHub] [calcite] danny0405 commented on a change in pull request #1493: [CALCITE-3396] Materialization matching succeeds when query and view …

[GitBox <gi...@apache.org>]

danny0405 commented on a change in pull request #1493: [CALCITE-3396] Materialization matching succeeds when query and view …
URL: https://github.com/apache/calcite/pull/1493#discussion_r333880147
 
 

 ##########
 File path: core/src/test/java/org/apache/calcite/test/MaterializationTest.java
 ##########
 @@ -2468,12 +2468,25 @@ private void checkSatisfiable(RexNode e, String s) {
     checkMaterialize(sql, sql);
   }
 
-  @Test public void testUnionToUnion() {
+  @Test public void testUnionToUnion0() {
     String sql0 = "select * from \"emps\" where \"empid\" < 300";
 
 Review comment:
   Can we avoid to use the test case name XXX 0 .. 1.. 2, and give them more meaningful names ? Thus, we can see the test content difference just from the name.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services