You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org> on 2010/01/22 08:42:21 UTC
[jira] Created: (HBASE-2156) HBASE-2037 broke Scan
HBASE-2037 broke Scan
---------------------
Key: HBASE-2156
URL: https://issues.apache.org/jira/browse/HBASE-2156
Project: Hadoop HBase
Issue Type: Bug
Affects Versions: 0.20.3
Reporter: Jean-Daniel Cryans
Assignee: Jean-Daniel Cryans
Priority: Blocker
Fix For: 0.20.3
Paul Ambrose wrote to the mailing list about some tests he has that doesn't pass on 0.20.3RC1-2. Looking into the issue it appears that this modification:
{code}
public Scan addFamily(byte [] family) {
familyMap.remove(family);
- familyMap.put(family, null);
+ familyMap.put(family, EMPTY_NAVIGABLE_SET);
return this;
}
{code}
Makes it that when you use addColumn after that you put qualifiers into EMPTY_NAVIGABLE_SET which is static hence shared among all scanners after that like META scanners when calling tableExists.
This was introduced by HBASE-2037.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HBASE-2156) HBASE-2037 broke Scan
Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Daniel Cryans resolved HBASE-2156.
---------------------------------------
Resolution: Fixed
Fix Version/s: 0.21.0
Hadoop Flags: [Reviewed]
I committed the fix to branch and a to-the-point test to branch and trunk per Benoit's comment.
> HBASE-2037 broke Scan
> ---------------------
>
> Key: HBASE-2156
> URL: https://issues.apache.org/jira/browse/HBASE-2156
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.3
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Priority: Blocker
> Fix For: 0.20.3, 0.21.0
>
> Attachments: HBASE-2156.patch
>
>
> Paul Ambrose wrote to the mailing list about some tests he has that doesn't pass on 0.20.3RC1-2. Looking into the issue it appears that this modification:
> {code}
> public Scan addFamily(byte [] family) {
> familyMap.remove(family);
> - familyMap.put(family, null);
> + familyMap.put(family, EMPTY_NAVIGABLE_SET);
> return this;
> }
> {code}
> Makes it that when you use addColumn after that you put qualifiers into EMPTY_NAVIGABLE_SET which is static hence shared among all scanners after that like META scanners when calling tableExists.
> This was introduced by HBASE-2037.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2156) HBASE-2037 broke Scan
Posted by "Benoit Sigoure (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12803634#action_12803634 ]
Benoit Sigoure commented on HBASE-2156:
---------------------------------------
+1, figured out the bug with JD and verified the patch.
The unit test it's adding could be more minimalist and straight-to-the-point but oh well...
> HBASE-2037 broke Scan
> ---------------------
>
> Key: HBASE-2156
> URL: https://issues.apache.org/jira/browse/HBASE-2156
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.3
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Priority: Blocker
> Fix For: 0.20.3
>
> Attachments: HBASE-2156.patch
>
>
> Paul Ambrose wrote to the mailing list about some tests he has that doesn't pass on 0.20.3RC1-2. Looking into the issue it appears that this modification:
> {code}
> public Scan addFamily(byte [] family) {
> familyMap.remove(family);
> - familyMap.put(family, null);
> + familyMap.put(family, EMPTY_NAVIGABLE_SET);
> return this;
> }
> {code}
> Makes it that when you use addColumn after that you put qualifiers into EMPTY_NAVIGABLE_SET which is static hence shared among all scanners after that like META scanners when calling tableExists.
> This was introduced by HBASE-2037.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-2156) HBASE-2037 broke Scan
Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Daniel Cryans updated HBASE-2156:
--------------------------------------
Attachment: HBASE-2156.patch
Patch that fixes the bug by verifying if the set is the static one. Also adds a unit tests and re-indents the previous one in the class (which was horribly wrong).
> HBASE-2037 broke Scan
> ---------------------
>
> Key: HBASE-2156
> URL: https://issues.apache.org/jira/browse/HBASE-2156
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.3
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Priority: Blocker
> Fix For: 0.20.3
>
> Attachments: HBASE-2156.patch
>
>
> Paul Ambrose wrote to the mailing list about some tests he has that doesn't pass on 0.20.3RC1-2. Looking into the issue it appears that this modification:
> {code}
> public Scan addFamily(byte [] family) {
> familyMap.remove(family);
> - familyMap.put(family, null);
> + familyMap.put(family, EMPTY_NAVIGABLE_SET);
> return this;
> }
> {code}
> Makes it that when you use addColumn after that you put qualifiers into EMPTY_NAVIGABLE_SET which is static hence shared among all scanners after that like META scanners when calling tableExists.
> This was introduced by HBASE-2037.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2156) HBASE-2037 broke Scan
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12803782#action_12803782 ]
stack commented on HBASE-2156:
------------------------------
+1
> HBASE-2037 broke Scan
> ---------------------
>
> Key: HBASE-2156
> URL: https://issues.apache.org/jira/browse/HBASE-2156
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.3
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Priority: Blocker
> Fix For: 0.20.3
>
> Attachments: HBASE-2156.patch
>
>
> Paul Ambrose wrote to the mailing list about some tests he has that doesn't pass on 0.20.3RC1-2. Looking into the issue it appears that this modification:
> {code}
> public Scan addFamily(byte [] family) {
> familyMap.remove(family);
> - familyMap.put(family, null);
> + familyMap.put(family, EMPTY_NAVIGABLE_SET);
> return this;
> }
> {code}
> Makes it that when you use addColumn after that you put qualifiers into EMPTY_NAVIGABLE_SET which is static hence shared among all scanners after that like META scanners when calling tableExists.
> This was introduced by HBASE-2037.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.