You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2022/05/06 09:14:43 UTC

[GitHub] [trafficserver] mrdg commented on pull request #8817: Fix `COMPRESSION_ERROR` on valid HPACK input

mrdg commented on PR #8817:
URL: https://github.com/apache/trafficserver/pull/8817#issuecomment-1119415598

   I found that my first commit still had problems: the `byte_boundary_crossed > 3` check still fails for some valid inputs. When a code is more than 3 bytes long, and starts right before a byte boundary, you still cross 4 byte boundaries. I think the better approach is to count the number of bits parsed and check that you don't exceed the length of longest code in the table. I did that in [f70728a](https://github.com/apache/trafficserver/pull/8817/commits/f70728ac342b07bffe8b0fbfd1c52d56f9ed333c). This should catch some other invalid inputs that the previous approach didn't catch (see added tests).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org