[GitHub] [incubator-liminal] aviemzur commented on a change in pull request #37: add installation gif

[GitBox <gi...@apache.org>]

aviemzur commented on a change in pull request #37:
URL: https://github.com/apache/incubator-liminal/pull/37#discussion_r613051262



##########
File path: liminal/runners/airflow/tasks/python.py
##########
@@ -58,11 +58,14 @@ def _volumes(self):
         volumes = []
         for volume_config in volumes_config:
             name = volume_config['volume']
+            claim_name = volume_config.get('claim_name')
+            if not claim_name and 'local' in volume_config:
+                claim_name = f'{name}-pvc'
             volume = Volume(
                 name=name,
                 configs={
                     'persistentVolumeClaim': {
-                        'claimName': f"{name}-pvc"
+                        'claimName': f"{claim_name}"

Review comment:
       The string interpolation here isn't necessary, can just use `claim_name`

##########
File path: liminal/kubernetes/volume_util.py
##########
@@ -116,7 +116,7 @@ def _create_persistent_volume_claim(pvc_name, volume_name, namespace):
         V1PersistentVolumeClaim(
             api_version='v1',
             kind='PersistentVolumeClaim',
-            metadata={'name': f'{volume_name}-pvc'},
+            metadata={'name': f'{pvc_name}'},

Review comment:
       The string interpolation here isn't necessary, can just use `pvc_name`
   
   

##########
File path: docs/source/liminal_aws_deploy.sh
##########
@@ -4,9 +4,9 @@ help() {
     echo "$0: Get Started"
     echo "Usage: $0 -o option"
 		echo "Liminal available options:          "
-		echo "clone"
-		echo "installation "
-		echo "deployment"
+		echo "install"
+		echo "build "

Review comment:
       Trailing space in the string




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org