[GitHub] [thrift] Jimexist commented on a diff in pull request #2628: THRIFT-5600: upgrade rust toolchain to 1.50

[GitBox <gi...@apache.org>]

Jimexist commented on code in PR #2628:
URL: https://github.com/apache/thrift/pull/2628#discussion_r906748230


##########
lib/rs/src/server/multiplexed.rs:
##########
@@ -170,7 +170,7 @@ fn split_ident_name(ident_name: &str) -> (Option<&str>, &str) {
             let (_, svc_call) = svc_call.split_at(1); // remove colon from service call name
             (Some(svc_name), svc_call)
         })
-        .or_else(|| Some((None, ident_name)))
+        .or(Some((None, ident_name)))

Review Comment:
   clippy fix



##########
lib/rs/src/server/multiplexed.rs:
##########
@@ -272,10 +272,10 @@ mod tests {
             _: &mut dyn TInputProtocol,
             _: &mut dyn TOutputProtocol,
         ) -> crate::Result<()> {
-            let res = self
-                .invoked
-                .compare_and_swap(false, true, Ordering::Relaxed);
-            if res {
+            let res =

Review Comment:
   API change



##########
lib/rs/src/server/multiplexed.rs:
##########
@@ -272,10 +272,10 @@ mod tests {
             _: &mut dyn TInputProtocol,
             _: &mut dyn TOutputProtocol,
         ) -> crate::Result<()> {
-            let res = self
-                .invoked
-                .compare_and_swap(false, true, Ordering::Relaxed);
-            if res {
+            let res =

Review Comment:
   API change due to deprecation



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org