You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@apr.apache.org by ji...@apache.org on 2014/01/25 21:07:53 UTC
svn commit: r1561384 - /apr/apr/trunk/shmem/unix/shm.c
Author: jim
Date: Sat Jan 25 20:07:52 2014
New Revision: 1561384
URL: http://svn.apache.org/r1561384
Log:
FIXME comment
Modified:
apr/apr/trunk/shmem/unix/shm.c
Modified: apr/apr/trunk/shmem/unix/shm.c
URL: http://svn.apache.org/viewvc/apr/apr/trunk/shmem/unix/shm.c?rev=1561384&r1=1561383&r2=1561384&view=diff
==============================================================================
--- apr/apr/trunk/shmem/unix/shm.c (original)
+++ apr/apr/trunk/shmem/unix/shm.c Sat Jan 25 20:07:52 2014
@@ -308,6 +308,7 @@ APR_DECLARE(apr_status_t) apr_shm_create
}
#endif /* APR_USE_SHMEM_MMAP_TMP */
#if APR_USE_SHMEM_MMAP_SHM
+ /* FIXME: SysV uses 0600... should we? */
tmpfd = shm_open(shm_name, O_RDWR | O_CREAT | O_EXCL, 0644);
if (tmpfd == -1) {
return errno;
@@ -534,6 +535,7 @@ APR_DECLARE(apr_status_t) apr_shm_attach
#if APR_USE_SHMEM_MMAP_SHM
const char *shm_name = make_shm_open_safe_name(filename, pool);
+ /* FIXME: SysV uses 0600... should we? */
tmpfd = shm_open(shm_name, O_RDWR, 0644);
if (tmpfd == -1) {
return errno;