You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/12/19 10:01:47 UTC
[GitHub] [kafka] showuon opened a new pull request, #13016: KAFKA-14498: reduce the startup nodes to avoid timeout error
showuon opened a new pull request, #13016:
URL: https://github.com/apache/kafka/pull/13016
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #13016: KAFKA-14498: reduce the startup nodes to avoid timeout error
Posted by GitBox <gi...@apache.org>.
showuon commented on PR #13016:
URL: https://github.com/apache/kafka/pull/13016#issuecomment-1360804418
@ableegoldman , this is to help make some tests reliable by decreasing the testing nodes (low risk). Do you think this should backport to 3.4?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on a diff in pull request #13016: KAFKA-14498: reduce the startup nodes to avoid timeout error
Posted by GitBox <gi...@apache.org>.
showuon commented on code in PR #13016:
URL: https://github.com/apache/kafka/pull/13016#discussion_r1052735530
##########
tools/src/test/java/org/apache/kafka/tools/MetadataQuorumCommandTest.java:
##########
@@ -53,12 +53,12 @@ public MetadataQuorumCommandTest(ClusterInstance cluster) {
* 3. Fewer brokers than controllers
*/
@ClusterTests({
- @ClusterTest(clusterType = Type.CO_KRAFT, brokers = 3, controllers = 3),
- @ClusterTest(clusterType = Type.KRAFT, brokers = 3, controllers = 3),
- @ClusterTest(clusterType = Type.CO_KRAFT, brokers = 3, controllers = 2),
- @ClusterTest(clusterType = Type.KRAFT, brokers = 3, controllers = 2),
- @ClusterTest(clusterType = Type.CO_KRAFT, brokers = 2, controllers = 3),
- @ClusterTest(clusterType = Type.KRAFT, brokers = 2, controllers = 3)
+ @ClusterTest(clusterType = Type.CO_KRAFT, brokers = 1, controllers = 1),
+ @ClusterTest(clusterType = Type.KRAFT, brokers = 1, controllers = 1),
Review Comment:
Good point! Let me use 2 + 2 nodes instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #13016: KAFKA-14498: reduce the startup nodes to avoid timeout error
Posted by GitBox <gi...@apache.org>.
showuon commented on PR #13016:
URL: https://github.com/apache/kafka/pull/13016#issuecomment-1360793825
> Actually, do we support running kraft with just 2 members in the controller quorum?
Yes, I don't see why we can't support that. The quorum of 2 members will be 2. It just doesn't tolerate missing any node.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #13016: KAFKA-14498: reduce the startup nodes to avoid timeout error
Posted by GitBox <gi...@apache.org>.
ijuma commented on PR #13016:
URL: https://github.com/apache/kafka/pull/13016#issuecomment-1360800889
I guess you're saying we don't care about the ability to tolerate failures in this particular test. Fair enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #13016: KAFKA-14498: reduce the startup nodes to avoid timeout error
Posted by GitBox <gi...@apache.org>.
showuon commented on PR #13016:
URL: https://github.com/apache/kafka/pull/13016#issuecomment-1360802090
> I guess you're saying we don't care about the ability to tolerate failures in this particular test. Fair enough.
Yes, you're right. Thanks for the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #13016: KAFKA-14498: reduce the startup nodes to avoid timeout error
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on PR #13016:
URL: https://github.com/apache/kafka/pull/13016#issuecomment-1367736649
@showuon yes, thanks, I'll backport it to 3.4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #13016: KAFKA-14498: reduce the startup nodes to avoid timeout error
Posted by GitBox <gi...@apache.org>.
showuon commented on PR #13016:
URL: https://github.com/apache/kafka/pull/13016#issuecomment-1357394768
@dengziming , please take a look. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on a diff in pull request #13016: KAFKA-14498: reduce the startup nodes to avoid timeout error
Posted by GitBox <gi...@apache.org>.
ijuma commented on code in PR #13016:
URL: https://github.com/apache/kafka/pull/13016#discussion_r1052279836
##########
tools/src/test/java/org/apache/kafka/tools/MetadataQuorumCommandTest.java:
##########
@@ -53,12 +53,12 @@ public MetadataQuorumCommandTest(ClusterInstance cluster) {
* 3. Fewer brokers than controllers
*/
@ClusterTests({
- @ClusterTest(clusterType = Type.CO_KRAFT, brokers = 3, controllers = 3),
- @ClusterTest(clusterType = Type.KRAFT, brokers = 3, controllers = 3),
- @ClusterTest(clusterType = Type.CO_KRAFT, brokers = 3, controllers = 2),
- @ClusterTest(clusterType = Type.KRAFT, brokers = 3, controllers = 2),
- @ClusterTest(clusterType = Type.CO_KRAFT, brokers = 2, controllers = 3),
- @ClusterTest(clusterType = Type.KRAFT, brokers = 2, controllers = 3)
+ @ClusterTest(clusterType = Type.CO_KRAFT, brokers = 1, controllers = 1),
+ @ClusterTest(clusterType = Type.KRAFT, brokers = 1, controllers = 1),
Review Comment:
The test name indicates it's testing replication, that doesn't happen if there's a single broker & controller, right?
##########
tools/src/test/java/org/apache/kafka/tools/MetadataQuorumCommandTest.java:
##########
@@ -53,12 +53,12 @@ public MetadataQuorumCommandTest(ClusterInstance cluster) {
* 3. Fewer brokers than controllers
*/
@ClusterTests({
- @ClusterTest(clusterType = Type.CO_KRAFT, brokers = 3, controllers = 3),
- @ClusterTest(clusterType = Type.KRAFT, brokers = 3, controllers = 3),
- @ClusterTest(clusterType = Type.CO_KRAFT, brokers = 3, controllers = 2),
- @ClusterTest(clusterType = Type.KRAFT, brokers = 3, controllers = 2),
- @ClusterTest(clusterType = Type.CO_KRAFT, brokers = 2, controllers = 3),
- @ClusterTest(clusterType = Type.KRAFT, brokers = 2, controllers = 3)
+ @ClusterTest(clusterType = Type.CO_KRAFT, brokers = 1, controllers = 1),
+ @ClusterTest(clusterType = Type.KRAFT, brokers = 1, controllers = 1),
Review Comment:
The test name indicates its testing replication, that doesn't happen if there's a single broker & controller, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #13016: KAFKA-14498: reduce the startup nodes to avoid timeout error
Posted by GitBox <gi...@apache.org>.
showuon commented on PR #13016:
URL: https://github.com/apache/kafka/pull/13016#issuecomment-1358764790
@ijuma , PR updated. I changed to 2 brokers + 2 controllers for `replication` test and `status` test, because we already have a `testOnlyOneBrokerAndOneController` to test 1 + 1 node case. Here, we should test multiple nodes case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #13016: KAFKA-14498: reduce the startup nodes to avoid timeout error
Posted by GitBox <gi...@apache.org>.
showuon commented on PR #13016:
URL: https://github.com/apache/kafka/pull/13016#issuecomment-1360802421
Failed tests are unrelated
```
Build / JDK 8 and Scala 2.12 / kafka.network.SocketServerTest.idleExpiryWithBufferedReceives()
Build / JDK 17 and Scala 2.13 / kafka.server.DynamicBrokerReconfigurationTest.testTrustStoreAlter(String).quorum=kraft
Build / JDK 17 and Scala 2.13 / org.apache.kafka.streams.integration.SmokeTestDriverIntegrationTest.[1] true
Build / JDK 11 and Scala 2.13 / org.apache.kafka.clients.consumer.CooperativeStickyAssignorTest.testLargeAssignmentAndGroupWithNonEqualSubscription()
Build / JDK 11 and Scala 2.13 / org.apache.kafka.clients.consumer.StickyAssignorTest.testLargeAssignmentAndGroupWithNonEqualSubscription()
Build / JDK 11 and Scala 2.13 / kafka.server.DynamicBrokerReconfigurationTest.testTrustStoreAlter(String).quorum=kraft
Build / JDK 11 and Scala 2.13 / org.apache.kafka.streams.integration.SmokeTestDriverIntegrationTest.[1] true
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon merged pull request #13016: KAFKA-14498: reduce the startup nodes to avoid timeout error
Posted by GitBox <gi...@apache.org>.
showuon merged PR #13016:
URL: https://github.com/apache/kafka/pull/13016
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org