You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by "Benedikt Ritter (JIRA)" <ji...@apache.org> on 2013/09/27 09:53:03 UTC

[jira] [Resolved] (LANG-804) Redundant check for zero in HashCodeBuilder ctor

     [ https://issues.apache.org/jira/browse/LANG-804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benedikt Ritter resolved LANG-804.
----------------------------------

    Resolution: Fixed
      Assignee: Benedikt Ritter

Closing this as fixed, since the initial issue has been resolved. Whether disallowing negative parameters makes sense can be discussed in another issue.
                
> Redundant check for zero in HashCodeBuilder ctor
> ------------------------------------------------
>
>                 Key: LANG-804
>                 URL: https://issues.apache.org/jira/browse/LANG-804
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.builder.*
>            Reporter: Sebb
>            Assignee: Benedikt Ritter
>            Priority: Minor
>             Fix For: 3.2
>
>
> The HashCodeBuilder(int, int) ctor checks both parameters for zero, as well as checking for an odd number.
> Zero is never odd, so the zero check could be eliminated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira