You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Leemoonsoo <gi...@git.apache.org> on 2016/07/13 02:02:51 UTC
[GitHub] zeppelin pull request #1171: [ZEPPELIN-1150] Table contents disappear 2nd ru...
GitHub user Leemoonsoo opened a pull request:
https://github.com/apache/zeppelin/pull/1171
[ZEPPELIN-1150] Table contents disappear 2nd run onwards
### What is this PR for?
Fix for [ZEPPELIN-1150](https://issues.apache.org/jira/browse/ZEPPELIN-1150).
### What type of PR is it?
Bug Fix
### Todos
* [x] - Recreate table on data refresh
* [x] - Better solution for [ZEPPELIN-1078](https://issues.apache.org/jira/browse/ZEPPELIN-1150) without performance degrade
### What is the Jira issue?
[ZEPPELIN-1150](https://issues.apache.org/jira/browse/ZEPPELIN-1150)
### How should this be tested?
Reproduce procedure described in the issue
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Leemoonsoo/zeppelin ZEPPELIN-1150
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1171.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1171
----
commit b3406b70aaa6337c3f442793fa289f91bd401790
Author: Lee moon soo <mo...@apache.org>
Date: 2016-07-13T02:00:51Z
Recreate table when (data) is refreshed
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1171: [ZEPPELIN-1150] Table contents disappear 2nd run onwar...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1171
Thanks @astroshim @corneadoug for review this!
Merge it into master if there're no more discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1171: [ZEPPELIN-1150] Table contents disappear 2nd run onwar...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1171
@Leemoonsoo Tested,
Fix for the table after re-run confirmed.
For the second item, I would keep the solution used in https://issues.apache.org/jira/browse/ZEPPELIN-1078
Since you changes do not bring any improvement regarding performance degrade.
(We still do a renderText, when the text result is the same as before)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1171: [ZEPPELIN-1150] Table contents disappear 2nd run onwar...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1171
@corneadoug 413 and 473 "together" are alternative fix for ZEPPELIN-1078 for better performance.
Without 413, applying 473 will bring ZEPPELIN-1078 problem again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1171: [ZEPPELIN-1150] Table contents disappear 2nd run onwar...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1171
I got a following build error.
```
[INFO] --- frontend-maven-plugin:0.0.25:grunt (grunt build) @ zeppelin-web ---
[INFO] Running 'grunt build --no-color' in /home/nflabs/tmp/zeppelin/zeppelin-web
[INFO] Running "jscs:all" (jscs) task
[INFO] disallowMultipleLineBreaks: ; and console.log("updateParagraph oldData %o, newData %o. type %o -> %o, mode %o -> %o", $scope.paragraph, data, oldType, newType, oldGraphMode, newGraphMode); should have at most 2 line(s) between them at src/app/notebook/paragraph/paragraph.controller.js :
[INFO] 412 | isEmpty(data.paragraph.result) !== isEmpty($scope.paragraph.result) ||
[INFO] 413 | data.paragraph.status === 'ERROR' || (data.paragraph.status === 'FINISHED' && statusChanged) ||
[INFO] 414 | (!newActiveApp && oldActiveApp !== newActiveApp);
[INFO] -----------------------------------------------------------------^
[INFO] 415 |
[INFO] 416 |
[INFO] >> 1 code style errors found!
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1171: [ZEPPELIN-1150] Table contents disappear 2nd run onwar...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/1171
I missed this (which solve the same problem as https://github.com/apache/zeppelin/pull/1182), let me check this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1171: [ZEPPELIN-1150] Table contents disappear 2nd run onwar...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/1171
\U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1171: [ZEPPELIN-1150] Table contents disappear 2nd run onwar...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1171
@astroshim Thanks for testing. Build error is addressed in last commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1171: [ZEPPELIN-1150] Table contents disappear 2nd run onwar...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1171
@Leemoonsoo I tested again, originally I was testing with previous `|| resultRefreshed`
473 does help the text rendering indeed. However I have the same improvement without 413 for both TABLE and TEXT types
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1171: [ZEPPELIN-1150] Table contents disappear 2nd run onwar...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1171
@Leemoonsoo I was testing with %spark only, while ZEPPELIN-1078's issue shows with %python.
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1171: [ZEPPELIN-1150] Table contents disappear 2nd run onwar...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1171
@corneadoug Try revert line 413 and 473. And then run paragraph multiple times (with table result). In my machine after 2~3 times without 413, 473 change, browser almost freeze.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1171: [ZEPPELIN-1150] Table contents disappear 2nd ru...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1171
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1171: [ZEPPELIN-1150] Table contents disappear 2nd run onwar...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1171
Build error has gone and working good!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1171: [ZEPPELIN-1150] Table contents disappear 2nd run onwar...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1171
@corneadoug I tried more and it looks like slowing down without 413 and 473 change is not consistently reproducible.
Anyway, logically, 413 and 473 change reduce text rendering from
4 times (rendering 4 status change FINISHED -> PENDING -> RUNNING -> FINISHED)
to
1 time (RUNNING -> FINISHED)
So, i'd like to keep it while it doesn't bring any side effect or increase complexity of code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---