Re: [PR] Fix matching against one of multiple env-variables pointing to one JDK [maven-toolchains-plugin]

["slawekjaranowski (via GitHub)" <gi...@apache.org>]

slawekjaranowski commented on code in PR #148:
URL: https://github.com/apache/maven-toolchains-plugin/pull/148#discussion_r3206766704


##########
pom.xml:
##########
@@ -146,4 +146,34 @@ under the License.
       </plugin>
     </plugins>
   </build>
+  <profiles>
+    <profile>
+      <id>run-its</id>
+      <build>
+        <plugins>
+          <plugin>
+            <groupId>org.codehaus.mojo</groupId>
+            <artifactId>build-helper-maven-plugin</artifactId>
+            <version>3.6.1</version>
+            <executions>
+              <execution>
+                <id>sanitize-java-home</id>
+                <goals>
+                  <goal>regex-property</goal>
+                </goals>
+                <!-- Prevent it-test failures on Windows due to interpretation of back-slashes in paths.-->

Review Comment:
   should be not needed at all, tollchains can be executed on windows as well



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org