You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/07/30 07:35:27 UTC
[GitHub] [incubator-tvm] electriclilies opened a new pull request #6174: [DOCS] Added casting to hybrid script doc and fixed pass infra doc
electriclilies opened a new pull request #6174:
URL: https://github.com/apache/incubator-tvm/pull/6174
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] electriclilies commented on a change in pull request #6174: [DOCS] Added casting to hybrid script doc and fixed pass infra doc
Posted by GitBox <gi...@apache.org>.
electriclilies commented on a change in pull request #6174:
URL: https://github.com/apache/incubator-tvm/pull/6174#discussion_r463173545
##########
File path: docs/dev/hybrid_script.rst
##########
@@ -91,3 +91,10 @@ Math Intrinsics
So far, these math intrinsics, ``log``, ``exp``, ``sigmoid``, ``tanh``, ``power``, and ``popcount``, are supported.
Math intrinsics will be imported by the decorator. Most of the intrinsics are borrowed by library implementation
except ``popcount`` and ``sigmoid``. I implemented them manually.
+
+
+Casting
+~~~~~~~
+
+You can cast values by using the keywords``uint8``, ``uint32``, ``uint64``, ``int8``, ``int16``, ``int32``, ``int64``,
Review comment:
Whoops forgot it :) should be fixed now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] zhiics commented on a change in pull request #6174: [DOCS] Added casting to hybrid script doc and fixed pass infra doc
Posted by GitBox <gi...@apache.org>.
zhiics commented on a change in pull request #6174:
URL: https://github.com/apache/incubator-tvm/pull/6174#discussion_r463103326
##########
File path: docs/dev/hybrid_script.rst
##########
@@ -91,3 +91,10 @@ Math Intrinsics
So far, these math intrinsics, ``log``, ``exp``, ``sigmoid``, ``tanh``, ``power``, and ``popcount``, are supported.
Math intrinsics will be imported by the decorator. Most of the intrinsics are borrowed by library implementation
except ``popcount`` and ``sigmoid``. I implemented them manually.
+
+
+Casting
+~~~~~~~
+
+You can cast values by using the keywords``uint8``, ``uint32``, ``uint64``, ``int8``, ``int16``, ``int32``, ``int64``,
Review comment:
Do we miss uint16?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on pull request #6174: [DOCS] Added casting to hybrid script doc and fixed pass infra doc
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #6174:
URL: https://github.com/apache/incubator-tvm/pull/6174#issuecomment-668331487
Thanks @electriclilies @zhiics !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen merged pull request #6174: [DOCS] Added casting to hybrid script doc and fixed pass infra doc
Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #6174:
URL: https://github.com/apache/incubator-tvm/pull/6174
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org