You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by GitBox <gi...@apache.org> on 2020/07/03 14:13:11 UTC

[GitHub] [bigtop] sekikn opened a new pull request #649: BIGTOP-3355. [Puppet] Make GPG check for repos a configuration and default to true

sekikn opened a new pull request #649:
URL: https://github.com/apache/bigtop/pull/649


   I added a little modification (only replaced a package name "gpg" with "gnupg") to the PR @evans-ye submitted in #639 so that it works with Debian 9.
   
   I tested this on Debian 9 and Ubuntu 16.04 as follows:
   
   * Disable local repo (= enable GPG check) on Debian 9:
   
   ```
   ~/repos/bigtop/provisioner/docker$ cat config_debian-9.yaml 
   
   (snip)
   
   docker:
           memory_limit: "4g"
           image: "bigtop/puppet:trunk-debian-9"
   
   repo: "http://repos.bigtop.apache.org/releases/1.4.0/debian/9/$(ARCH)"
   distro: debian
   components: [hdfs, yarn, mapreduce]
   enable_local_repo: false
   smoke_test_components: [hdfs, yarn, mapreduce]
   ~/repos/bigtop/provisioner/docker$ ./docker-hadoop.sh -d -C config_debian-9.yaml -c 1
   
   (snip)
   
   Notice: /Stage[main]/Bigtop_repo/Apt::Key[add_key]/Apt_key[add_key]/ensure: created
   
   (snip)
   
   Notice: Applied catalog in 380.05 seconds
   ~/repos/bigtop/provisioner/docker$ echo $?
   0
   ~/repos/bigtop/provisioner/docker$ docker exec -it 20200703213349r22366_bigtop_1 apt-key list
   /etc/apt/trusted.gpg
   --------------------
   pub   rsa4096 2019-03-30 [SC]
         BB95 B97B 1822 6C73 CB28  38D1 DBBF 9D42 B7B4 BD70
   uid           [ unknown] Evans Ye (CODE SIGNING KEY 2) <ev...@apache.org>
   sub   rsa4096 2019-03-30 [E]
   
   (snip)
   ```
   
   * Enable local repo (= disable GPG check), on Ubuntu 16.04:
   
   ```
   ~/bigtop/provisioner/docker$ cat config_ubuntu-16.04.yaml 
   
   (snip)
   
   docker:
           memory_limit: "4g"
           image:  "bigtop/puppet:trunk-ubuntu-16.04"
   
   repo: "http://repos.bigtop.apache.org/releases/1.4.0/ubuntu/16.04/$(ARCH)"
   distro: debian
   components: [hdfs, yarn, mapreduce]
   enable_local_repo: true
   smoke_test_components: [hdfs, yarn, mapreduce]
   ~/bigtop/provisioner/docker$ ./docker-hadoop.sh -d -C config_ubuntu-16.04.yaml -c 1
   
   (snip)
   
   Notice: /Stage[main]/Bigtop_repo/Apt::Conf[disable_keys]/Apt::Setting[conf-disable_keys]/File[/etc/apt/apt.conf.d/50disable_keys]/ensure: created
   
   (snip)
   
   Notice: Finished catalog run in 284.91 seconds
   ~/bigtop/provisioner/docker$ echo $?
   0
   ~/bigtop/provisioner/docker$ docker exec -it 20200703_135327_r28971_bigtop_1 apt-key list
   /etc/apt/trusted.gpg
   --------------------
   pub   1024D/437D05B5 2004-09-12
   uid                  Ubuntu Archive Automatic Signing Key <ft...@ubuntu.com>
   sub   2048g/79164387 2004-09-12
   
   pub   4096R/C0B21F32 2012-05-11
   uid                  Ubuntu Archive Automatic Signing Key (2012) <ft...@ubuntu.com>
   
   pub   4096R/EFE21092 2012-05-11
   uid                  Ubuntu CD Image Automatic Signing Key (2012) <cd...@ubuntu.com>
   
   pub   1024D/FBB75451 2004-12-30
   uid                  Ubuntu CD Image Automatic Signing Key <cd...@ubuntu.com>
   
   ~/bigtop/provisioner/docker$ 
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [bigtop] sekikn merged pull request #649: BIGTOP-3355. [Puppet] Make GPG check for repos a configuration and default to true

Posted by GitBox <gi...@apache.org>.
sekikn merged pull request #649:
URL: https://github.com/apache/bigtop/pull/649


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [bigtop] sekikn commented on pull request #649: BIGTOP-3355. [Puppet] Make GPG check for repos a configuration and default to true

Posted by GitBox <gi...@apache.org>.
sekikn commented on pull request #649:
URL: https://github.com/apache/bigtop/pull/649#issuecomment-653885352


   The original PR was from @evans-ye as #639, and I've already +1'd that except for my slight fix in this PR.
   So I'm going to merge this in accordance with Bigtop's CTR model.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org