You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2017/04/28 00:44:21 UTC
Review Request 58829: Fixed the implementation of per-role Suppress /
Revive calls.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58829/
-----------------------------------------------------------
Review request for mesos and Michael Park.
Bugs: MESOS-7430
https://issues.apache.org/jira/browse/MESOS-7430
Repository: mesos
Description
-------
The existing implementation uses a single suppression boolean which
results in incorrect handling of per-role suppression / revival.
See: https://issues.apache.org/jira/browse/MESOS-7430
Diffs
-----
src/master/allocator/mesos/hierarchical.hpp 219f508dacb3b372c12da3f15e07a3bf5f27e6e6
src/master/allocator/mesos/hierarchical.cpp 984a0a4e2671ee7bb2a3515849342f49f2c4e3aa
Diff: https://reviews.apache.org/r/58829/diff/1/
Testing
-------
make check
Thanks,
Benjamin Mahler
Re: Review Request 58829: Fixed the implementation of per-role
Suppress / Revive calls.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58829/#review173300
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On April 27, 2017, 5:44 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58829/
> -----------------------------------------------------------
>
> (Updated April 27, 2017, 5:44 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-7430
> https://issues.apache.org/jira/browse/MESOS-7430
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The existing implementation uses a single suppression boolean which
> results in incorrect handling of per-role suppression / revival.
>
> See: https://issues.apache.org/jira/browse/MESOS-7430
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp 219f508dacb3b372c12da3f15e07a3bf5f27e6e6
> src/master/allocator/mesos/hierarchical.cpp 984a0a4e2671ee7bb2a3515849342f49f2c4e3aa
>
>
> Diff: https://reviews.apache.org/r/58829/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>