[GitHub] [incubator-druid] himanshug commented on issue #8157: Enum of ResponseContext keys

[GitBox <gi...@apache.org>]

himanshug commented on issue #8157: Enum of ResponseContext keys
URL: https://github.com/apache/incubator-druid/pull/8157#issuecomment-516996774
 
 
   > Also improved ResponseContext serialization. Previously the result of serialization was truncated if its length was greater than the limit. I believe it would be better to keep the context structure and make it deserializable thus the process of serialization removes max-length fields completely from the context until the final result length doesn't exceed the limit.
   
   I haven't looked at the code , but this is definitely an incompatibility with previous behavior, so tagged the PR as such . It should also be mentioned in release notes. I don't think most customers would care about it.
   Now, if possible, a better strategy might be to retain all keys but trim the bigger ones so to keep serialized response limited.
   Or, don't change the behavior since we haven't had use cases where this has been a problem so far.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org