You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by vi...@apache.org on 2021/01/25 13:11:55 UTC
[superset] 19/38: fix: return appropriate response when payload has
error (#12575)
This is an automated email from the ASF dual-hosted git repository.
villebro pushed a commit to branch 1.0
in repository https://gitbox.apache.org/repos/asf/superset.git
commit a4d7e9c35da69f7ff57e27dbf7f92aab3f51527c
Author: Yongjie Zhao <yo...@gmail.com>
AuthorDate: Tue Jan 19 14:57:25 2021 +0800
fix: return appropriate response when payload has error (#12575)
---
superset/views/core.py | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/superset/views/core.py b/superset/views/core.py
index 2895340..2ef0e1a 100755
--- a/superset/views/core.py
+++ b/superset/views/core.py
@@ -421,9 +421,10 @@ class Superset(BaseSupersetView): # pylint: disable=too-many-public-methods
)
def get_raw_results(self, viz_obj: BaseViz) -> FlaskResponse:
- return self.json_response(
- {"data": viz_obj.get_df_payload()["df"].to_dict("records")}
- )
+ payload = viz_obj.get_df_payload()
+ if viz_obj.has_error(payload):
+ return json_error_response(payload=payload, status=400)
+ return self.json_response({"data": payload["df"].to_dict("records")})
def get_samples(self, viz_obj: BaseViz) -> FlaskResponse:
return self.json_response({"data": viz_obj.get_samples()})