[GitHub] [spark] tgravescs commented on a change in pull request #34326: [SPARK-37053][CORE] Add metrics to SparkHistoryServer

[GitBox <gi...@apache.org>]

tgravescs commented on a change in pull request #34326:
URL: https://github.com/apache/spark/pull/34326#discussion_r780369492



##########
File path: core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala
##########
@@ -157,6 +161,15 @@ class HistoryServer(
     contextHandler.setContextPath(HistoryServer.UI_PATH_PREFIX)
     contextHandler.addServlet(new ServletHolder(loaderServlet), "/*")
     attachHandler(contextHandler)
+
+    // Register history server source to history server metrics system.
+    cacheMetrics.init()

Review comment:
       why are we calling init here?  Doesn't this end up getting called twice?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org