[jira] [Resolved] (CALCITE-5414) Use DateTimeUtils to correctly convert between java.sql types and unix timestamps

["Julian Hyde (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CALCITE-5414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julian Hyde resolved CALCITE-5414.
----------------------------------
    Fix Version/s: 1.33.0
       Resolution: Fixed

Fixed in [0ad974c3|https://github.com/apache/calcite/commit/0ad974c308d74d2de4bb32f3cff66dc08a3bed59]; thanks for the PR, [~freastro]!

> Use DateTimeUtils to correctly convert between java.sql types and unix timestamps
> ---------------------------------------------------------------------------------
>
>                 Key: CALCITE-5414
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5414
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.32.0
>            Reporter: Gregory Hart
>            Assignee: Gregory Hart
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.33.0
>
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> Converting java.sql types to unix timestamps requires extra steps to also convert to the correct calendar. Unix timestamps should follow the proleptic Gregorian calendar as defined by ISO-8601. Java uses the standard Gregorian calendar for java.sql types and switches to the Julian calendar for dates before the Gregorian shift.
> The DateTimeUtils class in Avatica correctly handles the calendar conversions. Calcite should use those methods since its own methods do not currently convert between calendars.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)