[GitHub] [skywalking] wu-sheng commented on a change in pull request #4007: spring @Bean annotation was annotation to the method.

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #4007: spring @Bean annotation was annotation to the method.
URL: https://github.com/apache/skywalking/pull/4007#discussion_r354183315
 
 

 ##########
 File path: apm-sniffer/optional-plugins/optional-spring-plugins/spring-annotation-plugin/src/main/java/org/apache/skywalking/apm/plugin/spring/annotations/bean/SpringBeanInstrumentation.java
 ##########
 @@ -31,6 +31,6 @@
     public static final String ENHANCE_ANNOTATION = "org.springframework.context.annotation.Bean";
 
     @Override protected ClassMatch enhanceClass() {
-        return byClassAnnotationMatch(new String[] {ENHANCE_ANNOTATION});
+        return byMethodAnnotationMatch(new String[] {ENHANCE_ANNOTATION});
 
 Review comment:
   Method annotation? What is this usage? `@Bean` on the method?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services