[GitHub] [fineract] ptuomola commented on pull request #807: FINERACT-730: Fixing bootRun and removing embedded Tomcat

[GitBox <gi...@apache.org>]

ptuomola commented on pull request #807:
URL: https://github.com/apache/fineract/pull/807#issuecomment-623419612


   > @ptuomola this now fails in the (brand new...) `ClasspathHellDuplicatesCheckRuleTest` introduced in https://github.com/apache/fineract/pull/803/files, see [FINERACT-919](https://issues.apache.org/jira/browse/FINERACT-919) for background. Please shout here or there if that is not clear enough and you require assistance - without hearing from you, I'll assume that you'll figure it out, whenever you have time for this PR. - Again, we appreciate this contribution very much!
   
   Thanks - I've fixed the duplicates, and also had to upgrade the Docker Tomcat image to Tomcat 9 in order to get all of checks to pass. So that should all be OK now.
   
   My only concern about this pull request is: after this, Fineract will need Tomcat 9 or above to run. The WAR does not work on Tomcat 7/8 anymore as it has been compiled against Tomcat 9 JARs, and there are some classes that are not present in 7/8. Is that going to be a problem? I.e. are there people who are using Tomcat 7 and expecting Fineract to work? Do we need to communicate this to everyone somehow so that they are aware?
   
   If this is an issue, it might be possibility to build two versions of the WAR - one for Tomcat (including 7/8) and another one for Spring Boot. But if no one is using Tomcat 7/8 (or if we can expect people to upgrade to 9), then of course it would be good to keep things simple...
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org