You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/11/04 14:36:23 UTC
[GitHub] [shardingsphere] Jacob953 commented on a diff in pull request #21966: Dynamic load SQL parser test cases from MySQL and PostgreSQL
Jacob953 commented on code in PR #21966:
URL: https://github.com/apache/shardingsphere/pull/21966#discussion_r1014098409
##########
test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/engine/DynamicLoadingSQLParserParameterizedTest.java:
##########
@@ -61,16 +64,11 @@ private static Collection<Map<String, String>> getResponse(final String sqlCaseU
String casesRepo = patches[4];
String casesDirectory = patches[7];
String casesGitHubApiURL = "https://api.github.com/repos/" + casesOwner + "/" + casesRepo + "/contents/" + casesDirectory;
- String[] lines = getContent(casesGitHubApiURL).split("\\,");
- String nameItem = null;
- for (String each : lines) {
- if (each.contains("name")) {
- nameItem = each.split("\"")[3];
- } else if (each.contains("download_url")) {
- String downloadURLItem = each.split("\"")[3];
- result.add(ImmutableMap.of("name", nameItem, "download_url", downloadURLItem));
- }
- }
+ String casesGitHubApoContent = getContent(casesGitHubApiURL);
Review Comment:
Sorry about that. It should be `Api`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org