You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Daniel Pravat <dp...@outlook.com> on 2016/01/29 01:04:12 UTC
Re: Review Request 40936: Windows: Unified POSIX and Windows
implementation of `shell.hpp`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40936/
-----------------------------------------------------------
(Updated Jan. 29, 2016, 12:04 a.m.)
Review request for mesos, Alex Naparu, Alex Clemmer, M Lawindi, and Yi Sun.
Summary (updated)
-----------------
Windows: Unified POSIX and Windows implementation of `shell.hpp`.
Repository: mesos
Description (updated)
-------
Windows: Unified POSIX and Windows implementation of `shell.hpp`.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/shell.hpp b18cae1118302e18d2cfb7ce4089ab5079a01d1a
3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/shell.hpp bf737c87b8a337cc46e6c16d6fec2eef61e6ea05
3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 74af0077a39ef4cfa636b0b9e0c6b93eabc04bc8
3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 061bb4a9b9efe4ddd364f589175446b07152c315
Diff: https://reviews.apache.org/r/40936/diff/
Testing
-------
OSX: make check
Windows: Build
Thanks,
Daniel Pravat
Re: Review Request 40936: Windows: Unified POSIX and Windows
implementation of `shell.hpp`.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40936/#review116912
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On Jan. 29, 2016, 12:04 a.m., Daniel Pravat wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40936/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2016, 12:04 a.m.)
>
>
> Review request for mesos, Alex Naparu, Alex Clemmer, M Lawindi, and Yi Sun.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Unified POSIX and Windows implementation of `shell.hpp`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/shell.hpp b18cae1118302e18d2cfb7ce4089ab5079a01d1a
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/shell.hpp bf737c87b8a337cc46e6c16d6fec2eef61e6ea05
> 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 74af0077a39ef4cfa636b0b9e0c6b93eabc04bc8
> 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 061bb4a9b9efe4ddd364f589175446b07152c315
>
> Diff: https://reviews.apache.org/r/40936/diff/
>
>
> Testing
> -------
>
> OSX: make check
> Windows: Build
>
>
> Thanks,
>
> Daniel Pravat
>
>