You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by "xiazcy (via GitHub)" <gi...@apache.org> on 2024/09/17 03:34:22 UTC
[PR] Update Map serializer according to GraphBinaryV4 IO specs [tinkerpop]
xiazcy opened a new pull request, #2779:
URL: https://github.com/apache/tinkerpop/pull/2779
Changes:
* Refactored GraphBinary serializers in Java and Python to read and write the `value_flag` byte set by different serializers for special handling.
* Add ordered `value_flag` `0x02` to Map serializers in Java and Python drivers.
Neither changes are complex, but first one is rather extensive. The `value_flag` will not affect most types, except for `map` and `list`.
Note this branch was based off of [graphbinary-add-datetime](https://github.com/apache/tinkerpop/tree/graphbinary-add-datetime) feature branch, as such the PR is to that branch to minimize file diff and facilitate review. Target branch will be changed to `master-http` once the feature branch is merged in https://github.com/apache/tinkerpop/pull/2776.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update Map serializer according to GraphBinaryV4 IO specs [tinkerpop]
Posted by "xiazcy (via GitHub)" <gi...@apache.org>.
xiazcy commented on PR #2779:
URL: https://github.com/apache/tinkerpop/pull/2779#issuecomment-2364354342
> Have you considered the option of adding new types and serializers for OrderedMap and OrderedList (or set)?
Actually my wording might have been misleading, only Map will have the ordered flag. List is ordered by definition and Set not ordered, and we aren't changing those.
Lists however will be using the flag 0x02 for a different purpose (bulking), so this flag change was needed anyways. (see [devlist](https://lists.apache.org/thread/zsd7o7t6hqncc8hzkm47hkz3omdrfm9g) and [updated IO](https://github.com/apache/tinkerpop/blob/master-http/docs/src/dev/io/graphbinary.asciidoc))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update Map serializer according to GraphBinaryV4 IO specs [tinkerpop]
Posted by "vkagamlyk (via GitHub)" <gi...@apache.org>.
vkagamlyk commented on PR #2779:
URL: https://github.com/apache/tinkerpop/pull/2779#issuecomment-2357510319
Have you considered the option of adding new types and serializers for OrderedMap and OrderedList (or set)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update Map serializer according to GraphBinaryV4 IO specs [tinkerpop]
Posted by "spmallette (via GitHub)" <gi...@apache.org>.
spmallette commented on code in PR #2779:
URL: https://github.com/apache/tinkerpop/pull/2779#discussion_r1764893356
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/binary/types/BigDecimalSerializer.java:
##########
@@ -36,7 +36,7 @@ public BigDecimalSerializer() {
}
@Override
- protected BigDecimal readValue(final Buffer buffer, final GraphBinaryReader context) throws IOException {
+ protected BigDecimal readValue(final Buffer buffer, final GraphBinaryReader context, byte valueFlag) throws IOException {
Review Comment:
`valueFlag` should be `final` - please review all use of `final` in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update Map serializer according to GraphBinaryV4 IO specs [tinkerpop]
Posted by "xiazcy (via GitHub)" <gi...@apache.org>.
xiazcy commented on PR #2779:
URL: https://github.com/apache/tinkerpop/pull/2779#issuecomment-2374704895
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org