[GitHub] [cordova-lib] dpogue commented on a change in pull request #860: fix(cordova/util): Support requiring PlatformAPI from node_modules

[GitBox <gi...@apache.org>]

dpogue commented on a change in pull request #860:
URL: https://github.com/apache/cordova-lib/pull/860#discussion_r513174314



##########
File path: src/cordova/util.js
##########
@@ -301,14 +301,23 @@ function isDirectory (dir) {
 
 // Returns the API of the platform contained in `dir`.
 // Potential errors : module isn't found, can't load or doesn't implement the expected interface.
-function getPlatformApiFunction (dir) {
+function getPlatformApiFunction (dir, platform) {

Review comment:
       Apparently we were already passing in the platform name as a second parameter, but not using it 🤷🏼‍♂️ 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org