[GitHub] [superset] michael-s-molina commented on pull request #15363: chore: Improves the Select component UI/UX - iteration 3

[GitBox <gi...@apache.org>]

michael-s-molina commented on pull request #15363:
URL: https://github.com/apache/superset/pull/15363#issuecomment-868400133


   > Minor nit, or something for a future iteration: The Interactive Select might benefit from a separate "selected values" display, to prove that the `invertSelection` prop works as expected.
   
   @rusackas An interesting point here. Actually, the selected values are the same, we just change the icon from the checkmark to the forbidden one. It's just an indication that the selected items will be excluded. With this behavior in mind, do you think there is a more appropriate name for it or that's ok?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org