You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "BigDataDZ (via GitHub)" <gi...@apache.org> on 2026/10/10 13:21:07 UTC
[PR] docs: verify the workflow state docs against main (#3522) [maka]
BigDataDZ opened a new pull request, #6055:
URL: https://github.com/apache/maka/pull/6055
## Summary
The **Workflow state** group of the #3522 docs-verification campaign — with the same kind of scope correction the Managed workspace pass needed: **two of the group's four documents no longer exist**.
- `session-task-ledger-lifecycle.md` was removed by #4351 (SessionTodo Runtime Host authority cutover). The tracking issue's pointer is doubly stale: the `workflow_task_ledger_events` table it cited was itself dropped in #4400 (workflow schema 12), and the successor `docs/session-todo-lifecycle.md` already documents the removal. Nothing should be recreated.
- `deep-research-durable-workspace.md` was removed by #5554 (Deep Research retirement). `workflow_deep_research_events` survives only as a read-only legacy table ("the research writer is retired, but its stored events must survive upgrades" — `sqlite-workflow-schema.ts`).
This PR therefore verifies the **two surviving documents**; the tracking issue's group checklist needs the same correction.
## Verification results
Both surviving documents verified clean against `main`:
- `work-board-contract.md`: PASS — the DDL in the doc matches `sqlite-workflow-schema.ts` field-for-field, the workflow schema 8→9 migration history is accurate, page-size constants (`WORK_BOARD_DEFAULT_PAGE_SIZE=50`/`MAX=100`), `WORK_BOARD_MAX_LINKED_SESSIONS=1`, the `workBoard:linkSession` mutation boundary, and both test paths all check out. One bullet referencing the retired task-ledger table now notes the removal (#4400).
- `scheduled-task-unified.md`: PASS — all eight key files exist, `HostScheduledTaskCoordinator`, the `workflow_scheduled_tasks`/`workflow_scheduled_task_fires` tables (including the unique fire-claim constraint), both protocol methods and their preload allowlist entries, the four effect types, and the Desktop native-delivery path all check out against recent scheduled-task commits. The retired "separate Headless runtime" wording now points at the minimal Eval kernel and CLI headless invocation.
Both documents gain `translation_status`/`last_verified` front matter per the campaign convention (license comment directly after the closing delimiter, per the ASF source-header policy — the same check that flagged #6038/#6043).
Metadata-only plus two sentences; no code paths touched.
Refs #3522
## AI use
Select exactly one:
- [ ] No generative tool made a substantive contribution
- [x] Generative tooling made a substantive contribution
Tool(s) and scope: [ZCode](https://github.com/zai-org/ZCode) (GLM). Ran the doc-vs-code verification pass and drafted the corrections; the human contributor reviewed the findings and owns the result. Commits carry `Generated-by: ZCode`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] docs: verify the workflow state docs against main (#3522) [maka]
Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han merged PR #6055:
URL: https://github.com/apache/maka/pull/6055
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] docs: verify the workflow state docs against main (#3522) [maka]
Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han commented on code in PR #6055:
URL: https://github.com/apache/maka/pull/6055#discussion_r4237795283
##########
docs/architecture/scheduled-task-unified.md:
##########
@@ -72,7 +76,8 @@ Scheduled tasks keep Runtime Host resident even when the initiating client exits
requires no Desktop. Local and bot notifications wait durably for a native-effect provider before
crossing the delivery boundary. Once invocation starts, an unknown outcome is recorded as failed
and is never replayed. Other interactive clients can create and manage the global catalog through
-the same Host protocol. The separate Headless runtime is outside this interactive authority boundary.
+the same Host protocol. Standalone headless invocation (scripts and CI) runs through the minimal
Review Comment:
P2: Non-interactive invocation does not use a separate Eval kernel. maka run dispatches to runRuntimeHostTextCli and a Host session driver; the Eval Maka subject calls runHostedExecution, which selects INTERACTIVE_RUNTIME_HOST_COMPOSITION_ID and sends hosted.execution.start. Please describe these Host-owned execution paths and distinguish an isolated Eval State Root from independent execution authority before marking this document verified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] docs: verify the workflow state docs against main (#3522) [maka]
Posted by "BigDataDZ (via GitHub)" <gi...@apache.org>.
BigDataDZ commented on PR #6055:
URL: https://github.com/apache/maka/pull/6055#issuecomment-6100560981
Fixed in the follow-up commit — the sentence now says standalone headless invocation stays under the same Host-owned authority: `maka run` dispatches through `runRuntimeHostTextCli` to a Runtime Host, and the Eval harness drives the same interactive composition (`INTERACTIVE_RUNTIME_HOST_COMPOSITION_ID`) from an isolated Eval state root. The "minimal Eval kernel" wording is gone; the isolated-state-root vs separate-authority distinction is stated explicitly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org