[GitHub] [mynewt-nimble] KKopyscinski commented on a change in pull request #941: ble_sm: add Secure Connections Only mode

[GitBox <gi...@apache.org>]

KKopyscinski commented on a change in pull request #941:
URL: https://github.com/apache/mynewt-nimble/pull/941#discussion_r630824650



##########
File path: nimble/host/src/ble_att_svr.c
##########
@@ -284,6 +284,16 @@ ble_att_svr_check_perms(uint16_t conn_handle, int is_read,
     }
 
     ble_att_svr_get_sec_state(conn_handle, &sec_state);
+    /* In SC Only mode all characteristics requiring security
+     * require it on level 4
+     */
+    if (MYNEWT_VAL(BLE_SM_SC_ONLY)) {
+        if (sec_state.key_size != 128 ||

Review comment:
       Makes sense. It wasn't caught by tests as they only checked if key shorter than needed returns the error. I submitted a fix https://github.com/apache/mynewt-nimble/pull/977




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org