You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/09/29 13:51:57 UTC

[GitHub] [hudi] veenaypatil opened a new pull request #3732: [HUDI-2499] Making jdbc-url, user and pass as non-required field for …

veenaypatil opened a new pull request #3732:
URL: https://github.com/apache/hudi/pull/3732


   ## What is the purpose of the pull request
   
   - Currently `jdbc-url, user and pass` are required configs to be passed to `run_sync_tool.sh`  for every sync mode.
   - These configs are not required for HMS mode and hence marked as non-required.
   
   ## Brief change log
   
   - Modified `HiveSyncConfig` to remove `required` option from `jdbc-url, user and pass` options
   - Added nonNull checks in `JDBCExecutor`
   
   ## Verify this pull request
   
   This pull request is a trivial rework / code cleanup without any test coverage.
   
   ## Committer checklist
   
    - [X] Has a corresponding JIRA in PR title & commit
    
    - [X] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3732: [HUDI-2499] Make jdbc-url, user and pass as non-required for other sync-modes

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3732:
URL: https://github.com/apache/hudi/pull/3732#issuecomment-930199853






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] nsivabalan merged pull request #3732: [HUDI-2499] Make jdbc-url, user and pass as non-required for other sync-modes

Posted by GitBox <gi...@apache.org>.
nsivabalan merged pull request #3732:
URL: https://github.com/apache/hudi/pull/3732


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #3732: [HUDI-2499] Make jdbc-url, user and pass as non-required for other sync-modes

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3732:
URL: https://github.com/apache/hudi/pull/3732#issuecomment-930199853


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "546b457005237b5f7c2c51b9e1aef4b121110dc1",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "546b457005237b5f7c2c51b9e1aef4b121110dc1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 546b457005237b5f7c2c51b9e1aef4b121110dc1 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #3732: [HUDI-2499] Make jdbc-url, user and pass as non-required for other sync-modes

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3732:
URL: https://github.com/apache/hudi/pull/3732#issuecomment-930199853


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "546b457005237b5f7c2c51b9e1aef4b121110dc1",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "546b457005237b5f7c2c51b9e1aef4b121110dc1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 546b457005237b5f7c2c51b9e1aef4b121110dc1 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3732: [HUDI-2499] Make jdbc-url, user and pass as non-required for other sync-modes

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3732:
URL: https://github.com/apache/hudi/pull/3732#issuecomment-930199853


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "546b457005237b5f7c2c51b9e1aef4b121110dc1",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2462",
       "triggerID" : "546b457005237b5f7c2c51b9e1aef4b121110dc1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 546b457005237b5f7c2c51b9e1aef4b121110dc1 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2462) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3732: [HUDI-2499] Make jdbc-url, user and pass as non-required for other sync-modes

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3732:
URL: https://github.com/apache/hudi/pull/3732#issuecomment-930199853


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "546b457005237b5f7c2c51b9e1aef4b121110dc1",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2462",
       "triggerID" : "546b457005237b5f7c2c51b9e1aef4b121110dc1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 546b457005237b5f7c2c51b9e1aef4b121110dc1 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2462) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org