You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by misakuo <gi...@git.apache.org> on 2017/07/31 03:44:02 UTC
[GitHub] incubator-weex pull request #557: + [android] return contentSize on getCompo...
GitHub user misakuo opened a pull request:
https://github.com/apache/incubator-weex/pull/557
+ [android] return contentSize on getComponentRect when target compon…
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/misakuo/incubator-weex android-feature-contentSize-on-componentRect
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/557.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #557
----
commit adaf9cfe9c2d79c3ed855a32490d59068e0ee8ee
Author: misakuo <mi...@apache.org>
Date: 2017-07-31T03:35:46Z
+ [android] return contentSize on getComponentRect when target component implemented ContentMeasurable @notdanger
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #557: + [android] return contentSize on getCompo...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-weex/pull/557
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #557: + [android] return contentSize on getComponentRec...
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/557
<!--
0 failure:
4 warning: No Changelog chan..., This PR modify SD..., This PR should up..., Potential BREAK C...
1 messages
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Warnings</th>
</tr>
</thead>
<tbody><tr>
<td>:warning:</td>
<td>No Changelog changes!</td>
</tr>
<tr>
<td>:warning:</td>
<td>This PR modify SDK code without add/modify testcases.</td>
</tr>
<tr>
<td>:warning:</td>
<td>This PR should update related documents as well. </td>
</tr>
<tr>
<td>:warning:</td>
<td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/component/WXScroller.java</td>
</tr>
</tbody>
</table>
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Messages</th>
</tr>
</thead>
<tbody><tr>
<td>:book:</td>
<td>According to the blame info, we recommended @sospartan , @luics to be the reviewers.</td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---