You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu> on 2024/11/27 13:58:17 UTC

Change in asterixdb[neo]: [NO ISSUE][TEST] Remove invalid JVM args from tests

From Murtadha Hubail <mh...@apache.org>:

Murtadha Hubail has uploaded this change for review. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19136 )


Change subject: [NO ISSUE][TEST] Remove invalid JVM args from tests
......................................................................

[NO ISSUE][TEST] Remove invalid JVM args from tests

- user model changes: no
- storage format changes: no
- interface changes: no

Details:

- Remove invalid JVM args from tests.
- Fix resource computer test.

Ex-ref: MB-64402
Change-Id: I2c409b46fa0a23b8fe5c55eba06d95851ed2a08d
---
M asterixdb/asterix-app/pom.xml
M asterixdb/asterix-app/src/test/java/org/apache/asterix/app/resource/PlanStagesGeneratorTest.java
2 files changed, 26 insertions(+), 6 deletions(-)



  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/36/19136/1

diff --git a/asterixdb/asterix-app/pom.xml b/asterixdb/asterix-app/pom.xml
index 2285d77..42da7c9 100644
--- a/asterixdb/asterix-app/pom.xml
+++ b/asterixdb/asterix-app/pom.xml
@@ -407,7 +407,7 @@
                     -Dfile.encoding=UTF-8
                     -Xdebug
                     -Xrunjdwp:transport=dt_socket,server=y,address=8000,suspend=${debug.suspend.flag}
-                    -Xloggc:"${project.build.directory}/surefire-reports/SqlppExecutionTest-%p-gc.log" -XX:+PrintGC -XX:+PrintGCDateStamps -XX:GCLogFileSize=10M
+                    -Xloggc:"${project.build.directory}/surefire-reports/SqlppExecutionTest-%p-gc.log" -XX:+PrintGC
                   </argLine>
                 </configuration>
                 <goals>
diff --git a/asterixdb/asterix-app/src/test/java/org/apache/asterix/app/resource/PlanStagesGeneratorTest.java b/asterixdb/asterix-app/src/test/java/org/apache/asterix/app/resource/PlanStagesGeneratorTest.java
index 77d0e60..54edff9 100644
--- a/asterixdb/asterix-app/src/test/java/org/apache/asterix/app/resource/PlanStagesGeneratorTest.java
+++ b/asterixdb/asterix-app/src/test/java/org/apache/asterix/app/resource/PlanStagesGeneratorTest.java
@@ -85,7 +85,7 @@
         ets.setExecutionMode(UNPARTITIONED);
         ets.setPhysicalOperator(new EmptyTupleSourcePOperator());
 
-        AssignOperator assignOperator = new AssignOperator(Collections.emptyList(), null);
+        AssignOperator assignOperator = new AssignOperator(Collections.emptyList(), Collections.emptyList());
         assignOperator.setExecutionMode(UNPARTITIONED);
         assignOperator.setPhysicalOperator(new AssignPOperator());
         assignOperator.getInputs().add(new MutableObject<>(ets));
@@ -95,7 +95,7 @@
         exchange.setPhysicalOperator(new OneToOneExchangePOperator());
         exchange.getInputs().add(new MutableObject<>(assignOperator));
 
-        DistributeResultOperator resultOperator = new DistributeResultOperator(null, null, null);
+        DistributeResultOperator resultOperator = new DistributeResultOperator(Collections.emptyList(), null, null);
         resultOperator.setExecutionMode(UNPARTITIONED);
         resultOperator.setPhysicalOperator(new DistributeResultPOperator());
         resultOperator.getInputs().add(new MutableObject<>(exchange));
@@ -113,6 +113,7 @@
 
     @Test
     public void testNonBlockingGroupByOrderBy() throws AlgebricksException {
+        TestUtils.redirectLoggingToConsole();
         EmptyTupleSourceOperator ets = new EmptyTupleSourceOperator();
         ets.setExecutionMode(PARTITIONED);
         ets.setPhysicalOperator(new EmptyTupleSourcePOperator());
@@ -137,7 +138,7 @@
         orderOperator.setPhysicalOperator(new StableSortPOperator());
         orderOperator.getInputs().add(new MutableObject<>(groupByOperator));
 
-        DistributeResultOperator resultOperator = new DistributeResultOperator(null, null, null);
+        DistributeResultOperator resultOperator = new DistributeResultOperator(Collections.emptyList(), null, null);
         resultOperator.setExecutionMode(PARTITIONED);
         resultOperator.setPhysicalOperator(new DistributeResultPOperator());
         resultOperator.getInputs().add(new MutableObject<>(orderOperator));
@@ -218,7 +219,7 @@
         secondJoin.getInputs().add(new MutableObject<>(exchangeOperator1));
         secondJoin.getInputs().add(new MutableObject<>(exchangeOperator2));
 
-        DistributeResultOperator resultOperator = new DistributeResultOperator(null, null, null);
+        DistributeResultOperator resultOperator = new DistributeResultOperator(Collections.emptyList(), null, null);
         resultOperator.setExecutionMode(PARTITIONED);
         resultOperator.setPhysicalOperator(new DistributeResultPOperator());
         resultOperator.getInputs().add(new MutableObject<>(secondJoin));
@@ -279,7 +280,7 @@
         secondJoin.getInputs().add(new MutableObject<>(order1));
         secondJoin.getInputs().add(new MutableObject<>(order2));
 
-        DistributeResultOperator resultOperator = new DistributeResultOperator(null, null, null);
+        DistributeResultOperator resultOperator = new DistributeResultOperator(Collections.emptyList(), null, null);
         resultOperator.setExecutionMode(PARTITIONED);
         resultOperator.setPhysicalOperator(new DistributeResultPOperator());
         resultOperator.getInputs().add(new MutableObject<>(secondJoin));

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19136
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: neo
Gerrit-Change-Id: I2c409b46fa0a23b8fe5c55eba06d95851ed2a08d
Gerrit-Change-Number: 19136
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-MessageType: newchange