[GitHub] [lucene-solr] munendrasn commented on a change in pull request #597: [SOLR-13272] feat(facet/interval): support json facet requests for interval facet

[GitBox <gi...@apache.org>]

munendrasn commented on a change in pull request #597: [SOLR-13272] feat(facet/interval): support json facet requests for interval facet
URL: https://github.com/apache/lucene-solr/pull/597#discussion_r303986476
 
 

 ##########
 File path: solr/core/src/java/org/apache/solr/search/facet/FacetRange.java
 ##########
 @@ -299,8 +323,127 @@ private void createRangeList() throws IOException {
       actual_end = null;
     }
   }
-  
-  
+
+  private List<Range> parseInterval(Object input) {
+    //intervals :[{key:"set1",value:"[0,10]"}]
+    //@todo apoorv handle exception, sort orders
 
 Review comment:
   could you please validate the input? What is the `sort orders` here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org