You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by beargiles <gi...@git.apache.org> on 2015/11/24 02:25:18 UTC

[GitHub] commons-compress pull request: Pkware headers

GitHub user beargiles opened a pull request:

    https://github.com/apache/commons-compress/pull/5

    Pkware headers

    Added several classes reflecting the strong crypto headers for PKWARE encryption. This request does not implement encryption/decryption.
    
    This request does not reflect the strong crypto headers for WinZip encryption.
    
    This request does not reflect the legacy (weak) encryption algorithm for ZIP files.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/beargiles/commons-compress pkware-headers

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-compress/pull/5.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5
    
----
commit 37ee75061b070421b9db9944cf0085dd3d6c78e6
Author: Bear Giles <bg...@coyotesong.com>
Date:   2015-11-24T01:19:15Z

    Added headers to recognize PKWARE crypto headers.

commit 26281633654bac1ba5e85c03fad07307d0871187
Author: Bear Giles <bg...@coyotesong.com>
Date:   2015-11-24T01:22:22Z

    Removed unused imports.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

[GitHub] commons-compress pull request: Pkware headers

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/commons-compress/pull/5


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

[GitHub] commons-compress pull request: Pkware headers

Posted by bodewig <gi...@git.apache.org>.
Github user bodewig commented on the pull request:

    https://github.com/apache/commons-compress/pull/5#issuecomment-164276454
  
    Thanks
    
    I've merged you patch have a few questions - and would like to see tests :-)  Not sure whether you'd prefer to discuss this here, inside a new PR or on the dev list.
    
    I'm note sure why you've introduced the base class `PKWareExtraHeader`. It might be useful as a container but I don't see why the others inherit from it.
    
    Second, don't you want to register the new classes `ExtraFieldUtils`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org