You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/02 05:59:49 UTC
[GitHub] [incubator-superset] JasonD28 opened a new pull request #10762: fix: add validator information to email/slack alerts
JasonD28 opened a new pull request #10762:
URL: https://github.com/apache/incubator-superset/pull/10762
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
This PR updates alerts by adding the reason why a SQL-based alert was triggered.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Email:
Slack:
<img width="568" alt="Screen Shot 2020-09-01 at 10 52 47 PM" src="https://user-images.githubusercontent.com/32852580/91937000-dc6b4d00-eca5-11ea-92e8-bd5bf682ce7b.png">
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
- [x] local
- [x] unit test
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10762: fix: add validator information to email/slack alerts
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10762:
URL: https://github.com/apache/incubator-superset/pull/10762#issuecomment-685990772
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10762?src=pr&el=h1) Report
> Merging [#10762](https://codecov.io/gh/apache/incubator-superset/pull/10762?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/45f4c689a2ae1e56666c36340c4b27f9f05b5903?el=desc) will **decrease** coverage by `0.44%`.
> The diff coverage is `80.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10762?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10762 +/- ##
==========================================
- Coverage 61.11% 60.66% -0.45%
==========================================
Files 801 801
Lines 37754 37762 +8
Branches 3555 3555
==========================================
- Hits 23075 22910 -165
- Misses 14493 14666 +173
Partials 186 186
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `61.59% <ø> (ø)` | |
| #python | `60.12% <80.00%> (-0.72%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10762?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/10762/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.80% <75.00%> (-2.03%)` | :arrow_down: |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/10762/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `75.74% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10762/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10762/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/10762/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.16% <0.00%> (-12.50%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10762/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.85% <0.00%> (-10.77%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/10762/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/10762/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/10762/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10762/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `86.66% <0.00%> (-1.67%)` | :arrow_down: |
| ... and [2 more](https://codecov.io/gh/apache/incubator-superset/pull/10762/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10762?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10762?src=pr&el=footer). Last update [45f4c68...9624cf4](https://codecov.io/gh/apache/incubator-superset/pull/10762?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter commented on pull request #10762: fix: add validator information to email/slack alerts
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10762:
URL: https://github.com/apache/incubator-superset/pull/10762#issuecomment-685990772
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10762?src=pr&el=h1) Report
> Merging [#10762](https://codecov.io/gh/apache/incubator-superset/pull/10762?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/45f4c689a2ae1e56666c36340c4b27f9f05b5903?el=desc) will **decrease** coverage by `0.99%`.
> The diff coverage is `80.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10762?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10762 +/- ##
==========================================
- Coverage 61.11% 60.12% -1.00%
==========================================
Files 801 372 -429
Lines 37754 23791 -13963
Branches 3555 0 -3555
==========================================
- Hits 23075 14304 -8771
+ Misses 14493 9487 -5006
+ Partials 186 0 -186
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #python | `60.12% <80.00%> (-0.72%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10762?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/10762/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.80% <75.00%> (-2.03%)` | :arrow_down: |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/10762/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `75.74% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10762/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10762/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/10762/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.16% <0.00%> (-12.50%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10762/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.85% <0.00%> (-10.77%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/10762/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/10762/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/10762/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10762/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `86.66% <0.00%> (-1.67%)` | :arrow_down: |
| ... and [431 more](https://codecov.io/gh/apache/incubator-superset/pull/10762/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10762?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10762?src=pr&el=footer). Last update [45f4c68...9624cf4](https://codecov.io/gh/apache/incubator-superset/pull/10762?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10762: fix: add validator information to email/slack alerts
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10762:
URL: https://github.com/apache/incubator-superset/pull/10762#issuecomment-685990772
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10762?src=pr&el=h1) Report
> Merging [#10762](https://codecov.io/gh/apache/incubator-superset/pull/10762?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/1ee87cc4d1810163bd00788636291588ecbfcbdf?el=desc) will **increase** coverage by `1.88%`.
> The diff coverage is `80.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10762?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10762 +/- ##
==========================================
+ Coverage 59.23% 61.11% +1.88%
==========================================
Files 768 801 +33
Lines 36651 37774 +1123
Branches 3302 3555 +253
==========================================
+ Hits 21710 23086 +1376
+ Misses 14759 14502 -257
- Partials 182 186 +4
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `61.59% <ø> (?)` | |
| #python | `60.83% <80.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10762?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/10762/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.80% <75.00%> (-2.03%)` | :arrow_down: |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/10762/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `75.74% <100.00%> (ø)` | |
| [superset-frontend/src/views/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10762/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0FwcC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10762/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/views/menu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10762/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL21lbnUudHN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10762/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/views/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10762/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2luZGV4LnRzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10762/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10762/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10762/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [323 more](https://codecov.io/gh/apache/incubator-superset/pull/10762/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10762?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10762?src=pr&el=footer). Last update [1ee87cc...ee9838e](https://codecov.io/gh/apache/incubator-superset/pull/10762?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] bkyryliuk commented on a change in pull request #10762: fix: add validator information to email/slack alerts
Posted by GitBox <gi...@apache.org>.
bkyryliuk commented on a change in pull request #10762:
URL: https://github.com/apache/incubator-superset/pull/10762#discussion_r482299881
##########
File path: superset/models/alerts.py
##########
@@ -201,3 +202,15 @@ def alert(self) -> RelationshipProperty:
foreign_keys=[self.alert_id],
backref=backref("validators", cascade="all, delete-orphan"),
)
+
+ def __str__(self) -> str:
Review comment:
s/__str__/pretty_print
##########
File path: superset/tasks/schedules.py
##########
@@ -571,29 +572,31 @@ def deliver_alert(
# Set all the values for the alert report
# Alternate values are used in the case of a test alert
- # where an alert has no observations yet
+ # where an alert might not have a validator
recipients = recipients or alert.recipients
slack_channel = slack_channel or alert.slack_channel
- sql = alert.sql_observer[0].sql if alert.sql_observer else ""
- observation_value = (
- str(alert.observations[-1].value) if alert.observations else "Value"
+ validation_str = (
Review comment:
s/validation_str/ validation_error_message
##########
File path: superset/templates/email/alert.txt
##########
@@ -20,6 +20,7 @@
<p><b>SQL Statement:</b></p>
<code><mark style="background-color: LightGrey; font-size: 1.1em">{{sql}}</mark></code></p>
<p><b>SQL Result</b>: {{observation_value}}</p>
+<p><b>Reason For Alert</b>: {{validation_str}}</p>
Review comment:
let's change it here a bit:
```
Query:
Result:
Reason:
```
to keep it a bit simpler
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] bkyryliuk merged pull request #10762: fix: add validator information to email/slack alerts
Posted by GitBox <gi...@apache.org>.
bkyryliuk merged pull request #10762:
URL: https://github.com/apache/incubator-superset/pull/10762
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10762: fix: add validator information to email/slack alerts
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10762:
URL: https://github.com/apache/incubator-superset/pull/10762#issuecomment-685990772
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10762?src=pr&el=h1) Report
> Merging [#10762](https://codecov.io/gh/apache/incubator-superset/pull/10762?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/45f4c689a2ae1e56666c36340c4b27f9f05b5903?el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `80.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10762?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10762 +/- ##
==========================================
- Coverage 61.11% 60.83% -0.29%
==========================================
Files 801 801
Lines 37754 37762 +8
Branches 3555 3555
==========================================
- Hits 23075 22974 -101
- Misses 14493 14602 +109
Partials 186 186
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `61.59% <ø> (ø)` | |
| #python | `60.39% <80.00%> (-0.45%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10762?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/10762/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.80% <75.00%> (-2.03%)` | :arrow_down: |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/10762/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `75.74% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10762/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10762/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/10762/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `94.18% <0.00%> (-4.07%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/10762/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.43% <0.00%> (-2.57%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10762/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.05% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10762/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.28% <0.00%> (+0.67%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10762?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10762?src=pr&el=footer). Last update [45f4c68...9624cf4](https://codecov.io/gh/apache/incubator-superset/pull/10762?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org