You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by Petr Sumbera <Pe...@Sun.COM> on 2009/10/22 13:01:13 UTC
Re: Apache::SizeLimit + solaris Update 10
What is status of this issue? I don't see any related change in svn.
Thanks,
Petr
Adam Prime wrote:
>
> Fred Moyer wrote:
>> On Wed, Mar 18, 2009 at 7:14 PM, Adam Prime <ad...@utoronto.ca>
>> wrote:
>>> Fred suggested in resend these patches relative to the root of the
>>> distributions, so here they are. SizeLimit.patch is against the version
>>> of Apache2::SizeLimit in mod_perl 2.0.4 and generated via git diff.
>>> svn.SizeLimit.patch is against the version of SizeLimit in svn, and was
>>> generated with svn diff.
>>
>> This git diff doesn't match what I have in svn trunk for
>> Apache2/SizeLimit.pm,
>
> Thats because it's against the version in mod_perl 2.0.4, which is
> nothing like the version that currently in svn.
>
>> applied to your second part of the patch. I'd like to see the
>> $major/$minor logic use a couple of more parentheses to spell out
>> exactly what it is doing without having to worry about whether the
>> conditional parser in my head is interpreting this conditional
>> correctly.
>
> Do you want me to resubmit it like :
>
> (($major > 2) || ($major == 2 && $minor >= 6))
>
> I'm guessing that's what you mean.
>
> Adam
>
>
>> Index: lib/Apache/SizeLimit/Core.pm
>> ===================================================================
>> --- lib/Apache/SizeLimit/Core.pm (revision 755867)
>> +++ lib/Apache/SizeLimit/Core.pm (working copy)
>> @@ -131,7 +131,11 @@
>> }
>>
>> BEGIN {
>> - if ($Config{'osname'} eq 'solaris' && $Config{'osvers'} >= 2.6 ) {
>> + my ($major,$minor) = split('.',$Config{'osvers'});
>> +
>> + if ($Config{'osname'} eq 'solaris' &&
>> + ($major > 2 || $major == 2 && $minor >= 6)) {
>> +
>> *_platform_check_size = \&_solaris_2_6_size_check;
>> *_platform_getppid = \&_perl_getppid;
>>
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
> For additional commands, e-mail: dev-help@perl.apache.org
>
>
>
--
View this message in context: http://www.nabble.com/Apache%3A%3ASizeLimit-%2B-solaris-Update-10-tp22367060p26008045.html
Sent from the mod_perl - Dev mailing list archive at Nabble.com.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: Apache::SizeLimit + solaris Update 10 (new patch)
Posted by Adam Prime <ad...@utoronto.ca>.
Fred Moyer wrote:
> On Mon, Nov 16, 2009 at 8:25 AM, Fred Moyer <fr...@redhotpenguin.com> wrote:
>> On Mon, Nov 16, 2009 at 8:07 AM, Adam Prime <ad...@utoronto.ca> wrote:
>>> Any comments?
>> Looks pretty safe. +1
>
> That being said, I think this line:
>
> + ($major > 2 || ($major == 2 && $minor >= 6))) {
>
> is better written as
>
> (($major > 2) or (($major == 2) && ($minor >= 6))) {
>
> I can't remember the style guide off the top of my head, I have it
> plugged into my mod_perl perltidy instance.
>
Sure.
Adam
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: Apache::SizeLimit + solaris Update 10 (new patch)
Posted by Fred Moyer <fr...@redhotpenguin.com>.
On Mon, Nov 16, 2009 at 8:25 AM, Fred Moyer <fr...@redhotpenguin.com> wrote:
> On Mon, Nov 16, 2009 at 8:07 AM, Adam Prime <ad...@utoronto.ca> wrote:
>> Any comments?
>
> Looks pretty safe. +1
That being said, I think this line:
+ ($major > 2 || ($major == 2 && $minor >= 6))) {
is better written as
(($major > 2) or (($major == 2) && ($minor >= 6))) {
I can't remember the style guide off the top of my head, I have it
plugged into my mod_perl perltidy instance.
>
>>
>> Petr Sumbera wrote:
>>>
>>> Fred Moyer wrote:
>>>>
>>>> On Wed, Nov 11, 2009 at 7:56 PM, Adam Prime <ad...@utoronto.ca>
>>>> wrote:
>>>>>
>>>>> Petr Sumbera wrote:
>>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> can someone please reevaluate and commit attached patch? I would love
>>>>>> to
>>>>>> see
>>>>>> it in mod_perl 2.0.5 and 1.32 when they are released..
>>>>>>
>>>>>> Thanks,
>>>>>>
>>>>>> Petr
>>>>>>
>>>>>> http://old.nabble.com/file/p26284847/solaris.diff solaris.diff
>>>>>
>>>>> If no one objects in the next few day or so i'll commit this (finally)
>>>>
>>>> Can you post the patch inline to this email so everyone can review it?
>>>
>>> Resending (this time directly).
>>>
>>> Thanks,
>>>
>>> Petr
>>>
>>>
>>> ------------------------------------------------------------------------
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
>>> For additional commands, e-mail: dev-help@perl.apache.org
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
>> For additional commands, e-mail: dev-help@perl.apache.org
>>
>>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: Apache::SizeLimit + solaris Update 10 (new patch)
Posted by Fred Moyer <fr...@redhotpenguin.com>.
On Mon, Nov 16, 2009 at 8:07 AM, Adam Prime <ad...@utoronto.ca> wrote:
> Any comments?
Looks pretty safe. +1
>
> Petr Sumbera wrote:
>>
>> Fred Moyer wrote:
>>>
>>> On Wed, Nov 11, 2009 at 7:56 PM, Adam Prime <ad...@utoronto.ca>
>>> wrote:
>>>>
>>>> Petr Sumbera wrote:
>>>>>
>>>>> Hi,
>>>>>
>>>>> can someone please reevaluate and commit attached patch? I would love
>>>>> to
>>>>> see
>>>>> it in mod_perl 2.0.5 and 1.32 when they are released..
>>>>>
>>>>> Thanks,
>>>>>
>>>>> Petr
>>>>>
>>>>> http://old.nabble.com/file/p26284847/solaris.diff solaris.diff
>>>>
>>>> If no one objects in the next few day or so i'll commit this (finally)
>>>
>>> Can you post the patch inline to this email so everyone can review it?
>>
>> Resending (this time directly).
>>
>> Thanks,
>>
>> Petr
>>
>>
>> ------------------------------------------------------------------------
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
>> For additional commands, e-mail: dev-help@perl.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
> For additional commands, e-mail: dev-help@perl.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: Apache::SizeLimit + solaris Update 10 (new patch)
Posted by Adam Prime <ad...@utoronto.ca>.
Any comments?
Petr Sumbera wrote:
> Fred Moyer wrote:
>> On Wed, Nov 11, 2009 at 7:56 PM, Adam Prime <ad...@utoronto.ca>
>> wrote:
>>> Petr Sumbera wrote:
>>>> Hi,
>>>>
>>>> can someone please reevaluate and commit attached patch? I would
>>>> love to
>>>> see
>>>> it in mod_perl 2.0.5 and 1.32 when they are released..
>>>>
>>>> Thanks,
>>>>
>>>> Petr
>>>>
>>>> http://old.nabble.com/file/p26284847/solaris.diff solaris.diff
>>> If no one objects in the next few day or so i'll commit this (finally)
>>
>> Can you post the patch inline to this email so everyone can review it?
>
> Resending (this time directly).
>
> Thanks,
>
> Petr
>
>
> ------------------------------------------------------------------------
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
> For additional commands, e-mail: dev-help@perl.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: Apache::SizeLimit + solaris Update 10 (new patch)
Posted by Petr Sumbera <Pe...@Sun.COM>.
Fred Moyer wrote:
> On Wed, Nov 11, 2009 at 7:56 PM, Adam Prime <ad...@utoronto.ca> wrote:
>> Petr Sumbera wrote:
>>> Hi,
>>>
>>> can someone please reevaluate and commit attached patch? I would love to
>>> see
>>> it in mod_perl 2.0.5 and 1.32 when they are released..
>>>
>>> Thanks,
>>>
>>> Petr
>>>
>>> http://old.nabble.com/file/p26284847/solaris.diff solaris.diff
>> If no one objects in the next few day or so i'll commit this (finally)
>
> Can you post the patch inline to this email so everyone can review it?
Resending (this time directly).
Thanks,
Petr
Re: Apache::SizeLimit + solaris Update 10 (new patch)
Posted by Fred Moyer <fr...@redhotpenguin.com>.
On Wed, Nov 11, 2009 at 7:56 PM, Adam Prime <ad...@utoronto.ca> wrote:
> Petr Sumbera wrote:
>>
>> Hi,
>>
>> can someone please reevaluate and commit attached patch? I would love to
>> see
>> it in mod_perl 2.0.5 and 1.32 when they are released..
>>
>> Thanks,
>>
>> Petr
>>
>> http://old.nabble.com/file/p26284847/solaris.diff solaris.diff
>
> If no one objects in the next few day or so i'll commit this (finally)
Can you post the patch inline to this email so everyone can review it?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: Apache::SizeLimit + solaris Update 10 (new patch)
Posted by Adam Prime <ad...@utoronto.ca>.
Petr Sumbera wrote:
> Hi,
>
> can someone please reevaluate and commit attached patch? I would love to see
> it in mod_perl 2.0.5 and 1.32 when they are released..
>
> Thanks,
>
> Petr
>
> http://old.nabble.com/file/p26284847/solaris.diff solaris.diff
If no one objects in the next few day or so i'll commit this (finally)
Adam
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: Apache::SizeLimit + solaris Update 10 (new patch)
Posted by Petr Sumbera <Pe...@Sun.COM>.
Hi,
can someone please reevaluate and commit attached patch? I would love to see
it in mod_perl 2.0.5 and 1.32 when they are released..
Thanks,
Petr
http://old.nabble.com/file/p26284847/solaris.diff solaris.diff
--
View this message in context: http://old.nabble.com/Apache%3A%3ASizeLimit-%2B-solaris-Update-10-tp22367060p26284847.html
Sent from the mod_perl - Dev mailing list archive at Nabble.com.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: Apache::SizeLimit + solaris Update 10
Posted by Adam Prime <ad...@utoronto.ca>.
Petr Sumbera wrote:
> What is status of this issue? I don't see any related change in svn.
>
> Thanks,
>
> Petr
No one every replied to that last question, and nothing has happened
since then by the looks of things.
Adam
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org