You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/08/02 00:55:20 UTC
Review Request 61300: Imported `protoc` executable.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61300/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
This allows `protoc` to be used in `add_custom_command` with an implicit
dependency.
Diffs
-----
3rdparty/CMakeLists.txt f4feaf90b4750338cfa2127524a5e6556a86d063
Diff: https://reviews.apache.org/r/61300/diff/1/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 61300: Imported `protoc` executable.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61300/#review183100
-----------------------------------------------------------
Ship it!
May possibly squash into https://reviews.apache.org/r/61291/ before committing.
- Joseph Wu
On Aug. 1, 2017, 5:55 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61300/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2017, 5:55 p.m.)
>
>
> Review request for mesos and Joseph Wu.
>
>
> Bugs: MESOS-3576
> https://issues.apache.org/jira/browse/MESOS-3576
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This allows `protoc` to be used in `add_custom_command` with an implicit
> dependency.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt f4feaf90b4750338cfa2127524a5e6556a86d063
>
>
> Diff: https://reviews.apache.org/r/61300/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>