You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "echonesis (via GitHub)" <gi...@apache.org> on 2026/08/20 06:41:36 UTC

[PR] HDDS-16192. Refactor o.a.h.hdds.scm.protocol [ozone]

echonesis opened a new pull request, #11070:
URL: https://github.com/apache/ozone/pull/11070

   ## What changes were proposed in this pull request?
   `StorageContainerLocationProtocol` is an internal Java interface, while Hadoop RPC uses `StorageContainerLocationProtocolPB`, which extends the generated protobuf service interface.
   
   Both interfaces previously defined the protocol version and Kerberos metadata. However, the RPC server registration, client proxy, and failover provider use `StorageContainerLocationProtocolPB`, so the metadata on `StorageContainerLocationProtocol` was redundant and could incorrectly imply that this Java interface defines the wire protocol.
   
   This PR:
   - Removes `versionID` and `@KerberosInfo` from `StorageContainerLocationProtocol`.
   - Keeps the interface, its FQCN, methods, PB interface, translators, protobuf definitions, and `SCMPolicyProvider` unchanged.
   - Adds a focused test confirming that the historical protocol name, protocol version, and Kerberos metadata are provided by `StorageContainerLocationProtocolPB`.
   
   The historical FQCN is preserved because it remains the protocol name declared by `StorageContainerLocationProtocolPB` and is used by service authorization through `SCMPolicyProvider`.
   
   This change does not modify the protobuf service or Hadoop RPC protocol identity, so the wire protocol remains unchanged.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-16192
   
   ## How was this patch tested?
   
   Local Test
   ```shell
   mvn -pl :hdds-server-framework -am test \
     -Dtest=TestStorageContainerLocationProtocolPB \
     -Dsurefire.failIfNoSpecifiedTests=false \
     -DskipShade -DskipRecon -DskipDocs
   
   mvn -pl :ozone-integration-test test \
     -Dtest=TestSecureOzoneCluster#testSecureScmAndOmStartupAndAccessControl \
     -DskipShade -DskipRecon
   ```
   
   GitHub Actions CI: https://github.com/echonesis/ozone/actions/runs/32326358698
   
   Generated-by: Codex (GPT-5)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-16192. Refactor o.a.h.hdds.scm.protocol [ozone]

Posted by "chungen0126 (via GitHub)" <gi...@apache.org>.
chungen0126 commented on PR #11070:
URL: https://github.com/apache/ozone/pull/11070#issuecomment-5358529244

   Thanks for the cleanup! 
   Just wanted to mention that the `versionID` and `@KerberosInfo` in `SecretKeyProtocol`, `SCMSecurityProtocol`, and `StorageContainerDatanodeProtocol` seem to be redundant as well. We could probably clean those up in follow-up Jiras.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-16242. Remove redundant RPC metadata from StorageContainerLocationProtocol [ozone]

Posted by "echonesis (via GitHub)" <gi...@apache.org>.
echonesis commented on PR #11070:
URL: https://github.com/apache/ozone/pull/11070#issuecomment-5365701379

   > @echonesis , please create a subtask for this under [HDDS-16192](https://issues.apache.org/jira/browse/HDDS-16192) and update the title of this PR. Then, we can merge this.
   
   Thanks @szetszwo for the reminder. 
   I created [HDDS-16242](https://issues.apache.org/jira/browse/HDDS-16242) as a subtask under [HDDS-16192](https://issues.apache.org/jira/browse/HDDS-16192) and updated the PR title and Jira link accordingly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-16192. Refactor o.a.h.hdds.scm.protocol [ozone]

Posted by "chungen0126 (via GitHub)" <gi...@apache.org>.
chungen0126 merged PR #11070:
URL: https://github.com/apache/ozone/pull/11070


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-16242. Remove redundant RPC metadata from StorageContainerLocationProtocol [ozone]

Posted by "chungen0126 (via GitHub)" <gi...@apache.org>.
chungen0126 commented on PR #11070:
URL: https://github.com/apache/ozone/pull/11070#issuecomment-5367791963

   @ivandika3 Thanks for the reminder!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-16192. Refactor o.a.h.hdds.scm.protocol [ozone]

Posted by "ivandika3 (via GitHub)" <gi...@apache.org>.
ivandika3 commented on PR #11070:
URL: https://github.com/apache/ozone/pull/11070#issuecomment-5364151320

   @chungen0126 kind reminder to close the ticket.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-16242. Remove redundant RPC metadata from StorageContainerLocationProtocol [ozone]

Posted by "echonesis (via GitHub)" <gi...@apache.org>.
echonesis commented on PR #11070:
URL: https://github.com/apache/ozone/pull/11070#issuecomment-5366762174

   > Thanks for the cleanup! Just wanted to mention that the `versionID` and `@KerberosInfo` in `SecretKeyProtocol`, `SCMSecurityProtocol`, and `StorageContainerDatanodeProtocol` seem to be redundant as well. We could probably clean those up in follow-up Jiras.
   
   Thanks @chungen0126 for pointing these out! 
   I’ve created follow-up Jiras under HDDS-16192.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-16192. Refactor o.a.h.hdds.scm.protocol [ozone]

Posted by "echonesis (via GitHub)" <gi...@apache.org>.
echonesis commented on PR #11070:
URL: https://github.com/apache/ozone/pull/11070#issuecomment-5364234013

   Thanks @szetszwo for the review, @chungen0126 for the review and merge.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-16192. Refactor o.a.h.hdds.scm.protocol [ozone]

Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo commented on PR #11070:
URL: https://github.com/apache/ozone/pull/11070#issuecomment-5360286829

   @echonesis , please create a subtask for this under HDDS-16192 and update the title of this PR.  Then, we can merge this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org