[jira] [Created] (GUACAMOLE-556) Incorrect warning regarding decreasing timestamps in session recordings

["Michael Jumper (JIRA)" <ji...@apache.org>]

Michael Jumper created GUACAMOLE-556:
----------------------------------------

             Summary: Incorrect warning regarding decreasing timestamps in session recordings
                 Key: GUACAMOLE-556
                 URL: https://issues.apache.org/jira/browse/GUACAMOLE-556
             Project: Guacamole
          Issue Type: Bug
          Components: guacenc
            Reporter: Michael Jumper


In addition to timestamps sent within "sync" instructions at the end of a frame, session recordings may also contain timestamps associated with mouse events ("mouse" instructions) and, if enabled, keyboard events ("key" instructions). As these instructions are written by different threads and come from different sources, they are not guaranteed to be in sync with each other.

guacenc currently assumes that these timestamps _are_ in sync, and logs a warning if this is not the case:

{code:none}
guacenc: WARNING: Decreasing sync timestamp
{code}

This is technically incorrect. The warning should only be logged if "sync" timestamps are decreasing relative to other "sync" instructions, and the "mouse" timestamp should interpreted as advisory, defaulting to the last "sync" timestamp if it appears to come from the past.




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)